qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com,
	lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c
Date: Sat,  1 Mar 2014 08:40:35 +0100	[thread overview]
Message-ID: <1393659639-12959-10-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1393659639-12959-1-git-send-email-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 scripts/qapi-visit.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index b2a1c1c..97e9b11 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -494,10 +494,8 @@ fdecl.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DECL"))
 # have the functions defined, so we use -b option to provide control
 # over these cases
 if do_builtins:
-    fdef.write(guardstart("QAPI_VISIT_BUILTIN_VISITOR_DEF"))
     for typename in builtin_types:
         fdef.write(generate_visit_list(typename, None))
-    fdef.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DEF"))
 
 for expr in exprs:
     if expr.has_key('type'):
-- 
1.8.1.4

  parent reply	other threads:[~2014-03-01  7:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01  7:40 [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union " Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts Markus Armbruster
2014-03-01  7:40 ` Markus Armbruster [this message]
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors Markus Armbruster
2014-03-01 13:38   ` Eric Blake
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str() Markus Armbruster
2014-03-01  7:40 ` [Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct() Markus Armbruster
2014-03-03 16:21 ` [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393659639-12959-10-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).