From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJeXa-0004iW-Ah for qemu-devel@nongnu.org; Sat, 01 Mar 2014 02:41:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJeXR-0000v1-8K for qemu-devel@nongnu.org; Sat, 01 Mar 2014 02:40:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJeXR-0000ui-0L for qemu-devel@nongnu.org; Sat, 01 Mar 2014 02:40:49 -0500 From: Markus Armbruster Date: Sat, 1 Mar 2014 08:40:38 +0100 Message-Id: <1393659639-12959-13-git-send-email-armbru@redhat.com> In-Reply-To: <1393659639-12959-1-git-send-email-armbru@redhat.com> References: <1393659639-12959-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com Argument can't be null. No other Visitor method type_str() checks for null. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qapi-dealloc-visitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c index dc53545..d0ea118 100644 --- a/qapi/qapi-dealloc-visitor.c +++ b/qapi/qapi-dealloc-visitor.c @@ -131,9 +131,7 @@ static void qapi_dealloc_end_list(Visitor *v, Error **errp) static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name, Error **errp) { - if (obj) { - g_free(*obj); - } + g_free(*obj); } static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name, -- 1.8.1.4