From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, blauwirbel@gmail.com,
mdroth@linux.vnet.ibm.com, mst@redhat.com, armbru@redhat.com,
mtosatti@redhat.com, agraf@suse.de, ehabkost@redhat.com,
lcapitulino@redhat.com, peter.crosthwaite@petalogix.com,
quintela@redhat.com, imammedo@redhat.com, aliguori@amazon.com,
pbonzini@redhat.com, scottwood@freescale.com,
edgar.iglesias@gmail.com, afaerber@suse.de, rth@twiddle.net
Subject: [Qemu-devel] [PATCH RFC V2 7/9] qom: add object_property_is_set
Date: Sun, 2 Mar 2014 15:07:10 +0200 [thread overview]
Message-ID: <1393765632-2753-8-git-send-email-marcel.a@redhat.com> (raw)
In-Reply-To: <1393765632-2753-1-git-send-email-marcel.a@redhat.com>
Sometimes is not enough to get property's value,
but it is needed to know if the value was actually set.
This is especially useful when querying bool properties
and having different defaults on different scenarios.
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
include/qom/object.h | 11 +++++++++++
qom/object.c | 12 ++++++++++++
2 files changed, 23 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 9c7c361..4a4f026 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -319,6 +319,7 @@ typedef struct ObjectProperty
{
gchar *name;
gchar *type;
+ bool is_set;
ObjectPropertyAccessor *get;
ObjectPropertyAccessor *set;
ObjectPropertyRelease *release;
@@ -931,6 +932,16 @@ void object_property_set(Object *obj, struct Visitor *v, const char *name,
Error **errp);
/**
+ * object_property_is_set:
+ * @obj: the object
+ * @name: the name of the property
+ * @errp: returns an error if this function fails
+ *
+ * Returns: true if object's property is set, false otherwise.
+ */
+bool object_property_is_set(Object *obj, const char *name,
+ Error **errp);
+/**
* object_property_parse:
* @obj: the object
* @string: the string that will be used to parse the property value.
diff --git a/qom/object.c b/qom/object.c
index 660859c..5b9d8af 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -817,9 +817,21 @@ void object_property_set(Object *obj, Visitor *v, const char *name,
error_set(errp, QERR_PERMISSION_DENIED);
} else {
prop->set(obj, v, prop->opaque, name, errp);
+ prop->is_set = true;
}
}
+bool object_property_is_set(Object *obj, const char *name,
+ Error **errp)
+{
+ ObjectProperty *prop = object_property_find(obj, name, errp);
+ if (prop == NULL) {
+ return false;
+ }
+
+ return prop->is_set;
+}
+
void object_property_set_str(Object *obj, const char *value,
const char *name, Error **errp)
{
--
1.8.3.1
next prev parent reply other threads:[~2014-03-02 13:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 13:07 [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 1/9] hw/core: introduced qemu machine as " Marcel Apfelbaum
2014-03-03 12:56 ` Michael S. Tsirkin
2014-03-03 17:49 ` Andreas Färber
2014-03-03 19:06 ` Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 2/9] vl: use qemu machine QOM class instead of global machines list Marcel Apfelbaum
2014-03-03 12:58 ` Michael S. Tsirkin
2014-03-03 12:57 ` Paolo Bonzini
2014-03-03 13:03 ` Marcel Apfelbaum
2014-03-03 14:52 ` Andreas Färber
2014-03-03 15:05 ` Marcel Apfelbaum
2014-03-03 18:12 ` Andreas Färber
2014-03-03 19:54 ` Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 3/9] hw/boards: converted current_machine to be an instance of QemuMachineCLass Marcel Apfelbaum
2014-03-03 10:49 ` Paolo Bonzini
2014-03-03 12:07 ` Marcel Apfelbaum
2014-03-03 12:46 ` Paolo Bonzini
2014-03-03 12:11 ` Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 4/9] hw/machine: add qemu machine opts as properties to QemuMachineState Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 5/9] qapi: output visitor crashes qemu if it encounters a NULL value Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 6/9] vl.c: do not set 'type' property in obj_set_property Marcel Apfelbaum
2014-03-03 10:11 ` Paolo Bonzini
2014-03-03 12:09 ` Marcel Apfelbaum
2014-03-03 12:47 ` Paolo Bonzini
2014-03-02 13:07 ` Marcel Apfelbaum [this message]
2014-03-03 10:13 ` [Qemu-devel] [PATCH RFC V2 7/9] qom: add object_property_is_set Paolo Bonzini
2014-03-03 12:09 ` Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 8/9] machine-opts: replace qemu_opt_get by QOM QemuMachine queries Marcel Apfelbaum
2014-03-03 10:11 ` Paolo Bonzini
2014-03-03 12:10 ` Marcel Apfelbaum
2014-03-02 13:07 ` [Qemu-devel] [PATCH RFC V2 9/9] hw/core: mapped QemuOpts into QEMUMachineInitArgs fields to remove duplication Marcel Apfelbaum
2014-03-03 10:13 ` Paolo Bonzini
2014-03-03 12:10 ` Marcel Apfelbaum
2014-03-03 10:50 ` [Qemu-devel] [PATCH RFC V2 0/9] qemu-machine as a QOM object Paolo Bonzini
2014-03-03 12:07 ` Marcel Apfelbaum
2014-03-03 12:56 ` Paolo Bonzini
2014-03-03 13:17 ` Marcel Apfelbaum
2014-03-03 14:10 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393765632-2753-8-git-send-email-marcel.a@redhat.com \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).