qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join()
Date: Mon,  3 Mar 2014 16:28:44 +0100	[thread overview]
Message-ID: <1393860533-2063-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1393860533-2063-1-git-send-email-mreitz@redhat.com>

This function joins two QDicts by absorbing one into the other.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 include/qapi/qmp/qdict.h |  3 +++
 qobject/qdict.c          | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
index 1ddf97b..d68f4eb 100644
--- a/include/qapi/qmp/qdict.h
+++ b/include/qapi/qmp/qdict.h
@@ -16,6 +16,7 @@
 #include "qapi/qmp/qobject.h"
 #include "qapi/qmp/qlist.h"
 #include "qemu/queue.h"
+#include <stdbool.h>
 #include <stdint.h>
 
 #define QDICT_BUCKET_MAX 512
@@ -70,4 +71,6 @@ void qdict_flatten(QDict *qdict);
 void qdict_extract_subqdict(QDict *src, QDict **dst, const char *start);
 void qdict_array_split(QDict *src, QList **dst);
 
+void qdict_join(QDict *dest, QDict *src, bool overwrite);
+
 #endif /* QDICT_H */
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 42ec4c0..ea239f0 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -665,3 +665,35 @@ void qdict_array_split(QDict *src, QList **dst)
         qlist_append_obj(*dst, subqobj ?: QOBJECT(subqdict));
     }
 }
+
+/**
+ * qdict_join(): Absorb the src QDict into the dest QDict, that is, move all
+ * elements from src to dest.
+ *
+ * If an element from src has a key already present in dest, it will not be
+ * moved unless overwrite is true.
+ *
+ * If overwrite is true, the conflicting values in dest will be discarded and
+ * replaced by the corresponding values from src.
+ *
+ * Therefore, with overwrite being true, the src QDict will always be empty when
+ * this function returns. If overwrite is false, the src QDict will be empty
+ * iff there were no conflicts.
+ */
+void qdict_join(QDict *dest, QDict *src, bool overwrite)
+{
+    const QDictEntry *entry, *next;
+
+    entry = qdict_first(src);
+    while (entry) {
+        next = qdict_next(src, entry);
+
+        if (overwrite || !qdict_haskey(dest, entry->key)) {
+            qobject_incref(entry->value);
+            qdict_put_obj(dest, entry->key, entry->value);
+            qdict_del(src, entry->key);
+        }
+
+        entry = next;
+    }
+}
-- 
1.9.0

  reply	other threads:[~2014-03-03 15:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 15:28 [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Max Reitz
2014-03-03 15:28 ` Max Reitz [this message]
2014-03-05 15:55   ` [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() Benoît Canet
2014-03-05 16:01     ` Kevin Wolf
2014-03-05 16:06       ` Benoît Canet
2014-03-05 16:52   ` Eric Blake
2014-03-05 20:13     ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver Max Reitz
2014-03-05 16:04   ` Benoît Canet
2014-03-05 19:58     ` Max Reitz
2014-03-05 20:20       ` Benoît Canet
2014-03-05 20:21         ` Max Reitz
2014-03-05 21:18           ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 03/10] block/json: Add functions for cache control Max Reitz
2014-03-05 16:07   ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 04/10] block/json: Add functions for writing zeroes etc Max Reitz
2014-03-05 16:09   ` Benoît Canet
2014-03-05 20:03     ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status() Max Reitz
2014-03-05 16:11   ` Benoît Canet
2014-03-05 20:10     ` Max Reitz
2014-03-05 20:41       ` Benoît Canet
2014-03-05 20:44         ` Max Reitz
2014-03-05 23:22           ` Benoît Canet
2014-03-06 20:01             ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 06/10] block/json: Add ioctl etc Max Reitz
2014-03-05 16:14   ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 07/10] block/json: Add bdrv_get_specific_info() Max Reitz
2014-03-05 16:15   ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 08/10] block/raw_bsd: " Max Reitz
2014-03-05 16:16   ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name Max Reitz
2014-03-05 16:20   ` Benoît Canet
2014-03-05 20:11     ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol Max Reitz
2014-03-05 17:27   ` Eric Blake
2014-03-05 20:15     ` Max Reitz
2014-03-05 20:27       ` Eric Blake
2014-03-05 16:26 ` [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393860533-2063-2-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).