From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver
Date: Mon, 3 Mar 2014 16:28:45 +0100 [thread overview]
Message-ID: <1393860533-2063-3-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1393860533-2063-1-git-send-email-mreitz@redhat.com>
Add a JSON protocol driver which allows supplying block driver options
through the filename rather than separately. Other than that, it is a
pure passthrough driver which identifies itself as a filter.
This patch implements the functions bdrv_parse_filename(),
bdrv_file_open(), bdrv_close(), bdrv_aio_readv(), bdrv_aio_writev(),
bdrv_getlength(), bdrv_refresh_limits() and bdrv_get_info().
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/Makefile.objs | 2 +-
block/json.c | 136 ++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 137 insertions(+), 1 deletion(-)
create mode 100644 block/json.c
diff --git a/block/Makefile.objs b/block/Makefile.objs
index fd88c03..d4b70f4 100644
--- a/block/Makefile.objs
+++ b/block/Makefile.objs
@@ -5,7 +5,7 @@ block-obj-y += qed-check.o
block-obj-$(CONFIG_VHDX) += vhdx.o vhdx-endian.o vhdx-log.o
block-obj-$(CONFIG_QUORUM) += quorum.o
block-obj-y += parallels.o blkdebug.o blkverify.o
-block-obj-y += snapshot.o qapi.o
+block-obj-y += snapshot.o qapi.o json.o
block-obj-$(CONFIG_WIN32) += raw-win32.o win32-aio.o
block-obj-$(CONFIG_POSIX) += raw-posix.o
block-obj-$(CONFIG_LINUX_AIO) += linux-aio.o
diff --git a/block/json.c b/block/json.c
new file mode 100644
index 0000000..6d63cf6
--- /dev/null
+++ b/block/json.c
@@ -0,0 +1,136 @@
+/*
+ * JSON filename wrapper protocol driver
+ *
+ * Copyright (c) 2014 Red Hat Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "qemu-common.h"
+#include "block/block_int.h"
+#include "qapi/qmp/qdict.h"
+#include "qapi/qmp/qjson.h"
+
+static void json_parse_filename(const char *filename, QDict *options,
+ Error **errp)
+{
+ QObject *file_options_obj;
+ QDict *full_options;
+
+ if (!strstart(filename, "json:", &filename)) {
+ error_setg(errp, "Unknown protocol prefix for JSON block driver");
+ return;
+ }
+
+ file_options_obj = qobject_from_json(filename);
+ if (!file_options_obj) {
+ error_setg(errp, "Could not parse the JSON options");
+ return;
+ }
+
+ if (qobject_type(file_options_obj) != QTYPE_QDICT) {
+ qobject_decref(file_options_obj);
+ error_setg(errp, "Invalid JSON object");
+ return;
+ }
+
+ full_options = qdict_new();
+ qdict_put_obj(full_options, "x-options", file_options_obj);
+ qdict_flatten(full_options);
+
+ qdict_join(options, full_options, true);
+ assert(qdict_size(full_options) == 0);
+ QDECREF(full_options);
+}
+
+static int json_open(BlockDriverState *bs, QDict *options, int flags,
+ Error **errp)
+{
+ int ret;
+
+ assert(bs->file == NULL);
+ ret = bdrv_open_image(&bs->file, NULL, options, "x-options", flags, false,
+ errp);
+ if (ret < 0) {
+ return ret;
+ }
+
+ return 0;
+}
+
+static void json_close(BlockDriverState *bs)
+{
+}
+
+static BlockDriverAIOCB *json_aio_readv(BlockDriverState *bs,
+ int64_t sector_num, QEMUIOVector *qiov,
+ int nb_sectors,
+ BlockDriverCompletionFunc *cb,
+ void *opaque)
+{
+ return bdrv_aio_readv(bs->file, sector_num, qiov, nb_sectors, cb, opaque);
+}
+
+static BlockDriverAIOCB *json_aio_writev(BlockDriverState *bs,
+ int64_t sector_num, QEMUIOVector *qiov,
+ int nb_sectors,
+ BlockDriverCompletionFunc *cb,
+ void *opaque)
+{
+ return bdrv_aio_writev(bs->file, sector_num, qiov, nb_sectors, cb, opaque);
+}
+
+static int64_t json_getlength(BlockDriverState *bs)
+{
+ return bdrv_getlength(bs->file);
+}
+
+static int json_refresh_limits(BlockDriverState *bs)
+{
+ bs->bl = bs->file->bl;
+ return 0;
+}
+
+static int json_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
+{
+ return bdrv_get_info(bs->file, bdi);
+}
+
+static BlockDriver bdrv_json = {
+ .format_name = "json",
+ .protocol_name = "json",
+ .instance_size = 0,
+
+ .bdrv_parse_filename = json_parse_filename,
+ .bdrv_file_open = json_open,
+ .bdrv_close = json_close,
+
+ .bdrv_aio_readv = json_aio_readv,
+ .bdrv_aio_writev = json_aio_writev,
+
+ .has_variable_length = true,
+ .bdrv_getlength = json_getlength,
+
+ .bdrv_refresh_limits = json_refresh_limits,
+ .bdrv_get_info = json_get_info,
+
+ .authorizations = { true, true },
+};
+
+static void bdrv_json_init(void)
+{
+ bdrv_register(&bdrv_json);
+}
+
+block_init(bdrv_json_init);
--
1.9.0
next prev parent reply other threads:[~2014-03-03 15:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 15:28 [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() Max Reitz
2014-03-05 15:55 ` Benoît Canet
2014-03-05 16:01 ` Kevin Wolf
2014-03-05 16:06 ` Benoît Canet
2014-03-05 16:52 ` Eric Blake
2014-03-05 20:13 ` Max Reitz
2014-03-03 15:28 ` Max Reitz [this message]
2014-03-05 16:04 ` [Qemu-devel] [PATCH 02/10] block/json: Add JSON protocol driver Benoît Canet
2014-03-05 19:58 ` Max Reitz
2014-03-05 20:20 ` Benoît Canet
2014-03-05 20:21 ` Max Reitz
2014-03-05 21:18 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 03/10] block/json: Add functions for cache control Max Reitz
2014-03-05 16:07 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 04/10] block/json: Add functions for writing zeroes etc Max Reitz
2014-03-05 16:09 ` Benoît Canet
2014-03-05 20:03 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status() Max Reitz
2014-03-05 16:11 ` Benoît Canet
2014-03-05 20:10 ` Max Reitz
2014-03-05 20:41 ` Benoît Canet
2014-03-05 20:44 ` Max Reitz
2014-03-05 23:22 ` Benoît Canet
2014-03-06 20:01 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 06/10] block/json: Add ioctl etc Max Reitz
2014-03-05 16:14 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 07/10] block/json: Add bdrv_get_specific_info() Max Reitz
2014-03-05 16:15 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 08/10] block/raw_bsd: " Max Reitz
2014-03-05 16:16 ` Benoît Canet
2014-03-03 15:28 ` [Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name Max Reitz
2014-03-05 16:20 ` Benoît Canet
2014-03-05 20:11 ` Max Reitz
2014-03-03 15:28 ` [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol Max Reitz
2014-03-05 17:27 ` Eric Blake
2014-03-05 20:15 ` Max Reitz
2014-03-05 20:27 ` Eric Blake
2014-03-05 16:26 ` [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393860533-2063-3-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).