qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Claudio Fontana <claudio.fontana@gmail.com>
Subject: [Qemu-devel] [PATCH 10/10] tcg-aarch64: Remove nop from qemu_st slow path
Date: Tue,  4 Mar 2014 09:04:10 -0800	[thread overview]
Message-ID: <1393952650-16802-11-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1393952650-16802-1-git-send-email-rth@twiddle.net>

Commit 023261ef851b22a04f6c5d76da870051031757a6 failed to remove a
nop that's no longer required.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/aarch64/tcg-target.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index d75d685..f43eb67 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target.c
@@ -764,11 +764,6 @@ static inline void tcg_out_subi(TCGContext *s, TCGType ext,
     tcg_out32(s, base | aimm | (rn << 5) | rd);
 }
 
-static inline void tcg_out_nop(TCGContext *s)
-{
-    tcg_out32(s, 0xd503201f);
-}
-
 #ifdef CONFIG_SOFTMMU
 /* helper signature: helper_ret_ld_mmu(CPUState *env, target_ulong addr,
  *                                     int mmu_idx, uintptr_t ra)
@@ -822,8 +817,6 @@ static void tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
     tcg_out_movi(s, TCG_TYPE_I64, TCG_REG_TMP,
                  (intptr_t)qemu_st_helpers[lb->opc & 3]);
     tcg_out_callr(s, TCG_REG_TMP);
-
-    tcg_out_nop(s);
     tcg_out_goto(s, (tcg_target_long)lb->raddr);
 }
 
-- 
1.8.5.3

  parent reply	other threads:[~2014-03-04 17:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 17:04 [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 01/10] tcg-aarch64: Enable builtin disassembler Richard Henderson
2014-03-05 12:03   ` Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check Richard Henderson
2014-03-05 12:03   ` [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundantCPU_TLB_ENTRY_BITS checkk Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 03/10] tcg-aarch64: Change all ext variables to TCGType Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based on TCG_OPF_64BIT Richard Henderson
2014-03-05 12:08   ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based onTCG_OPF_64BITT Alex Bennée
2014-03-05 17:17     ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext basedonTCG_OPF_64BITTT Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi in tcg_out_op Richard Henderson
2014-03-05 12:11   ` [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_out_opp Alex Bennée
2014-03-05 14:47     ` Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loads in tcg_out_op Richard Henderson
2014-03-05 12:14   ` [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loadsin tcg_out_opp Alex Bennée
2014-03-05 14:53     ` Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp Richard Henderson
2014-03-05 12:15   ` [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_immparameter from tcg_out_cmpp Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 08/10] tcg-aarch64: Use intptr_t apropriately Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 09/10] tcg-aarch64: Simplify tcg_out_ldst_9 encoding Richard Henderson
2014-03-04 17:04 ` Richard Henderson [this message]
2014-03-06 10:06 ` [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393952650-16802-11-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=claudio.fontana@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).