* [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call
@ 2014-03-04 20:00 Andreas Färber
2014-03-04 20:12 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2014-03-04 20:00 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, peter.maydell, Andreas Färber, Stefan Hajnoczi
Supply a required Error ** argument to qemu_gluster_init() in
qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
block/gluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index 54ee9b7..fe7a10c 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -364,7 +364,7 @@ static int qemu_gluster_reopen_prepare(BDRVReopenState *state,
gconf = g_malloc0(sizeof(GlusterConf));
- reop_s->glfs = qemu_gluster_init(gconf, state->bs->filename);
+ reop_s->glfs = qemu_gluster_init(gconf, state->bs->filename, errp);
if (reop_s->glfs == NULL) {
ret = -errno;
goto exit;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call
2014-03-04 20:00 [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call Andreas Färber
@ 2014-03-04 20:12 ` Stefan Hajnoczi
2014-03-04 20:18 ` Andreas Färber
2014-03-04 20:37 ` Jeff Cody
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2014-03-04 20:12 UTC (permalink / raw)
To: Andreas Färber
Cc: Kevin Wolf, Peter Maydell, qemu-devel, Stefan Hajnoczi
On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> Supply a required Error ** argument to qemu_gluster_init() in
> qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> block/gluster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixed my Gluster build environment, this shouldn't happen again in the future.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call
2014-03-04 20:12 ` Stefan Hajnoczi
@ 2014-03-04 20:18 ` Andreas Färber
2014-03-04 20:37 ` Jeff Cody
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Färber @ 2014-03-04 20:18 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, Peter Maydell, qemu-devel, Stefan Hajnoczi
Am 04.03.2014 21:12, schrieb Stefan Hajnoczi:
> On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber <afaerber@suse.de> wrote:
>> Supply a required Error ** argument to qemu_gluster_init() in
>> qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
>>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> block/gluster.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixed my Gluster build environment, this shouldn't happen again in the future.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, v2 sent with improved commit message.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call
2014-03-04 20:12 ` Stefan Hajnoczi
2014-03-04 20:18 ` Andreas Färber
@ 2014-03-04 20:37 ` Jeff Cody
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Cody @ 2014-03-04 20:37 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Peter Maydell, Andreas Färber, Stefan Hajnoczi,
qemu-devel
On Tue, Mar 04, 2014 at 09:12:14PM +0100, Stefan Hajnoczi wrote:
> On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> > Supply a required Error ** argument to qemu_gluster_init() in
> > qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
> >
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Andreas Färber <afaerber@suse.de>
> > ---
> > block/gluster.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixed my Gluster build environment, this shouldn't happen again in the future.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
Sorry Stefan, I should have rebased my _reopen patches on Paolo's
error message improvement series.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-04 20:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 20:00 [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call Andreas Färber
2014-03-04 20:12 ` Stefan Hajnoczi
2014-03-04 20:18 ` Andreas Färber
2014-03-04 20:37 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).