* [Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call
@ 2014-03-04 20:17 Andreas Färber
2014-03-04 20:25 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2014-03-04 20:17 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, peter.maydell, Andreas Färber, Stefan Hajnoczi
Commit adccfbcd6020e928db93b2b4faf0dbd05ffbe016 (block: gluster - add
reopen support.) did not supply the qemu_gluster_init() Error **
argument, needed since commit a7451cb850d115f257080aff3fbc54f255ebf8f7
(gluster: correctly propagate errors).
Pass through qemu_gluster_reopen_prepare()'s errp, as done in
qemu_gluster_open().
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
block/gluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index 54ee9b7..fe7a10c 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -364,7 +364,7 @@ static int qemu_gluster_reopen_prepare(BDRVReopenState *state,
gconf = g_malloc0(sizeof(GlusterConf));
- reop_s->glfs = qemu_gluster_init(gconf, state->bs->filename);
+ reop_s->glfs = qemu_gluster_init(gconf, state->bs->filename, errp);
if (reop_s->glfs == NULL) {
ret = -errno;
goto exit;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call
2014-03-04 20:17 [Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call Andreas Färber
@ 2014-03-04 20:25 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2014-03-04 20:25 UTC (permalink / raw)
To: Andreas Färber; +Cc: Kevin Wolf, QEMU Developers, Stefan Hajnoczi
On 4 March 2014 20:17, Andreas Färber <afaerber@suse.de> wrote:
> Commit adccfbcd6020e928db93b2b4faf0dbd05ffbe016 (block: gluster - add
> reopen support.) did not supply the qemu_gluster_init() Error **
> argument, needed since commit a7451cb850d115f257080aff3fbc54f255ebf8f7
> (gluster: correctly propagate errors).
>
> Pass through qemu_gluster_reopen_prepare()'s errp, as done in
> qemu_gluster_open().
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Applied to master, thanks. (Unfortunately my build machine isn't
running a new enough ubuntu to be able to build the glusterfs
support.)
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-04 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 20:17 [Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call Andreas Färber
2014-03-04 20:25 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).