From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: bcketchum@gmail.com, Corey Minyard <cminyard@mvista.com>,
hwd@huawei.com, afaerber@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PATCH 4/7] qemu-char: remove free of chr from win_stdio_close
Date: Tue, 4 Mar 2014 18:38:54 -0600 [thread overview]
Message-ID: <1393979937-9082-5-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1393979937-9082-1-git-send-email-minyard@acm.org>
From: Corey Minyard <cminyard@mvista.com>
This will result in a double free on close, because it's freed
in qemu_chr_delete() right after calling the close function.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
qemu-char.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index 6d6dd36..4ac131d 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2105,7 +2105,6 @@ static void win_stdio_close(CharDriverState *chr)
}
g_free(chr->opaque);
- g_free(chr);
}
static CharDriverState *qemu_chr_open_stdio(CharDriverState *chr,
--
1.8.3.1
next prev parent reply other threads:[~2014-03-05 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 0:38 [Qemu-devel] [PATCH 0/7] Allow a client chardev to reconnect if disconnected minyard
2014-03-05 0:38 ` [Qemu-devel] [PATCH 1/7] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts minyard
2014-03-05 0:38 ` [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected minyard
2014-03-06 6:47 ` Weidong Huang
2014-03-06 17:18 ` Corey Minyard
2014-03-06 17:41 ` Michael S. Tsirkin
2014-03-06 7:43 ` Michael S. Tsirkin
2014-03-06 18:04 ` Corey Minyard
2014-03-06 18:43 ` Michael S. Tsirkin
2014-03-05 0:38 ` [Qemu-devel] [PATCH 3/7] qemu-char: Wait until socket connect to report connected minyard
2014-03-05 0:38 ` minyard [this message]
2014-03-05 0:38 ` [Qemu-devel] [PATCH 5/7] qemu-char: Close fd at end of file minyard
2014-03-05 0:38 ` [Qemu-devel] [PATCH 6/7] qemu-char: Clean up error handling in qmp_chardev_add minyard
2014-03-05 0:38 ` [Qemu-devel] [PATCH 7/7] console: Don't use the console if NULL minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393979937-9082-5-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=afaerber@suse.de \
--cc=bcketchum@gmail.com \
--cc=cminyard@mvista.com \
--cc=hwd@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).