From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKzsv-0004jM-Ow for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKzsp-0000gS-Vz for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:33 -0500 Received: from mail-oa0-x22c.google.com ([2607:f8b0:4003:c02::22c]:44437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKzsp-0000gN-RV for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:27 -0500 Received: by mail-oa0-f44.google.com with SMTP id n16so325634oag.17 for ; Tue, 04 Mar 2014 16:40:27 -0800 (PST) Sender: Corey Minyard From: minyard@acm.org Date: Tue, 4 Mar 2014 18:38:54 -0600 Message-Id: <1393979937-9082-5-git-send-email-minyard@acm.org> In-Reply-To: <1393979937-9082-1-git-send-email-minyard@acm.org> References: <1393979937-9082-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH 4/7] qemu-char: remove free of chr from win_stdio_close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: bcketchum@gmail.com, Corey Minyard , hwd@huawei.com, afaerber@suse.de, mst@redhat.com From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 6d6dd36..4ac131d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2105,7 +2105,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); } static CharDriverState *qemu_chr_open_stdio(CharDriverState *chr, -- 1.8.3.1