From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Andreas Faerber <afaerber@suse.de>,
Anthony Liguori <aliguori@amazon.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/4] qom: link property fixes
Date: Wed, 5 Mar 2014 10:40:24 +0100 [thread overview]
Message-ID: <1394012428-11678-1-git-send-email-stefanha@redhat.com> (raw)
v2:
* A NULL set() callback should make the property read-only
There are two problems with QOM link properties:
1. There are refcount leaks in many object_property_add_link() callers.
2. There is no way to prevent link properties from being set after a device is
realized.
This patch series fixes these issues by extending the
object_property_add_link() function.
Stefan Hajnoczi (4):
qom: split object_property_set_link()
qom: make QOM link property unref optional
qom: add set() argument to object_property_add_link()
virtio-rng: avoid default_backend refcount leak
hw/core/qdev-properties.c | 12 ++++
hw/core/qdev.c | 9 ++-
hw/dma/xilinx_axidma.c | 16 ++++--
hw/net/xilinx_axienet.c | 16 ++++--
hw/pcmcia/pxa2xx.c | 5 +-
hw/s390x/s390-virtio-bus.c | 4 +-
hw/s390x/virtio-ccw.c | 4 +-
hw/virtio/virtio-pci.c | 4 +-
hw/virtio/virtio-rng.c | 7 ++-
include/hw/qdev-properties.h | 11 ++++
include/qom/object.h | 19 ++++++-
qom/object.c | 130 ++++++++++++++++++++++++++++++++-----------
ui/console.c | 4 +-
13 files changed, 191 insertions(+), 50 deletions(-)
--
1.8.5.3
next reply other threads:[~2014-03-05 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 9:40 Stefan Hajnoczi [this message]
2014-03-05 9:40 ` [Qemu-devel] [PATCH v2 1/4] qom: split object_property_set_link() Stefan Hajnoczi
2014-03-05 9:40 ` [Qemu-devel] [PATCH v2 2/4] qom: make QOM link property unref optional Stefan Hajnoczi
2014-03-05 9:40 ` [Qemu-devel] [PATCH v2 3/4] qom: add set() argument to object_property_add_link() Stefan Hajnoczi
2014-03-05 9:40 ` [Qemu-devel] [PATCH v2 4/4] virtio-rng: avoid default_backend refcount leak Stefan Hajnoczi
2014-03-05 13:29 ` [Qemu-devel] [PATCH v2 0/4] qom: link property fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394012428-11678-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).