From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL8K0-0005fD-BE for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:41:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WL8Jv-00066M-2i for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:41:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL8Ju-00066A-Ov for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:40:58 -0500 From: Stefan Hajnoczi Date: Wed, 5 Mar 2014 10:40:28 +0100 Message-Id: <1394012428-11678-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1394012428-11678-1-git-send-email-stefanha@redhat.com> References: <1394012428-11678-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/4] virtio-rng: avoid default_backend refcount leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini , Andreas Faerber , KONRAD Frederic QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio-rng.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 8efe0aa..ddba756 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -162,6 +162,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp) OBJECT(vrng->conf.default_backend), NULL); + /* The child property took a reference, we can safely drop ours now */ + object_unref(OBJECT(vrng->conf.default_backend)); + object_property_set_link(OBJECT(dev), OBJECT(vrng->conf.default_backend), "rng", NULL); -- 1.8.5.3