From: Marcel Apfelbaum <marcel.a@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, lcapitulino@redhat.com, blauwirbel@gmail.com,
aliguori@amazon.com, pbonzini@redhat.com, imammedo@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass
Date: Wed, 05 Mar 2014 19:59:46 +0200 [thread overview]
Message-ID: <1394042386.2663.0.camel@localhost.localdomain> (raw)
In-Reply-To: <53176093.10406@redhat.com>
On Wed, 2014-03-05 at 10:36 -0700, Eric Blake wrote:
> On 03/05/2014 10:30 AM, Marcel Apfelbaum wrote:
> > In order to allow attaching machine options to a machine instance,
> > current_machine is converted into MachineState.
> > As a first step of deprecating QEMUMachine, some of the functions
> > were modified to return MachineCLass.
>
> s/MachineCLass/MachineClass/ here and in subject
Thanks, I'll take care of it
Marcel
>
> >
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> > ---
>
> I'll leave the actual review to others, just pointing out the typo.
>
next prev parent reply other threads:[~2014-03-05 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:30 [Qemu-devel] [PATCH v3 0/3] qemu-machine as a QOM object Marcel Apfelbaum
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 1/3] hw/core: introduced qemu machine as " Marcel Apfelbaum
2014-03-06 22:43 ` Andreas Färber
2014-03-07 11:31 ` Andreas Färber
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 2/3] vl: use qemu machine QOM class instead of global machines list Marcel Apfelbaum
2014-03-06 22:55 ` Andreas Färber
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass Marcel Apfelbaum
2014-03-05 17:36 ` Eric Blake
2014-03-05 17:59 ` Marcel Apfelbaum [this message]
2014-03-06 23:44 ` Andreas Färber
2014-03-07 1:16 ` Alexey Kardashevskiy
2014-03-07 5:40 ` Marcel Apfelbaum
2014-03-07 5:32 ` Marcel Apfelbaum
2014-03-07 11:27 ` Andreas Färber
2014-03-07 16:22 ` Marcel Apfelbaum
2014-03-07 16:27 ` Paolo Bonzini
2014-03-07 17:30 ` Andreas Färber
2014-03-07 20:41 ` Marcel Apfelbaum
2014-03-11 15:44 ` Marcel Apfelbaum
2014-03-11 16:48 ` Andreas Färber
2014-03-11 19:28 ` Marcel Apfelbaum
2014-03-07 8:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394042386.2663.0.camel@localhost.localdomain \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).