From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andreas Faerber <afaerber@suse.de>,
Anthony Liguori <aliguori@amazon.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 0/5] qom: link property fixes
Date: Wed, 5 Mar 2014 21:51:19 +0100 [thread overview]
Message-ID: <1394052684-14362-1-git-send-email-stefanha@redhat.com> (raw)
v3:
* Split first commit for easier reviewing [afaerber]
* Turn bool argument into flags bitmask [pbonzini]
* Rename set() callback to check() [pbonzini]
* Rename object_property_default_set_link() to
object_property_allow_set_link()
* Rename qdev_prop_default_set_link() to
qdev_prop_allow_set_link_before_realize()
v2:
* A NULL set() callback should make the property read-only
There are two problems with QOM link properties:
1. There are refcount leaks in many object_property_add_link() callers.
2. There is no way to prevent link properties from being set after a device is
realized.
This patch series fixes these issues by extending the
object_property_add_link() function.
Stefan Hajnoczi (5):
qom: split object_property_set_link()
qom: don't make link NULL on object_property_set_link() failure
qom: make QOM link property unref optional
qom: add check() argument to object_property_add_link()
virtio-rng: avoid default_backend refcount leak
hw/core/qdev-properties.c | 12 ++++
hw/core/qdev.c | 10 +++-
hw/dma/xilinx_axidma.c | 20 +++++--
hw/net/xilinx_axienet.c | 20 +++++--
hw/pcmcia/pxa2xx.c | 4 +-
hw/s390x/s390-virtio-bus.c | 4 +-
hw/s390x/virtio-ccw.c | 4 +-
hw/virtio/virtio-pci.c | 4 +-
hw/virtio/virtio-rng.c | 7 ++-
include/hw/qdev-properties.h | 11 ++++
include/qom/object.h | 29 +++++++++-
qom/object.c | 130 ++++++++++++++++++++++++++++++++-----------
ui/console.c | 5 +-
13 files changed, 211 insertions(+), 49 deletions(-)
--
1.8.5.3
next reply other threads:[~2014-03-05 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:51 Stefan Hajnoczi [this message]
2014-03-05 20:51 ` [Qemu-devel] [PATCH v3 1/5] qom: split object_property_set_link() Stefan Hajnoczi
2014-03-05 20:51 ` [Qemu-devel] [PATCH v3 2/5] qom: don't make link NULL on object_property_set_link() failure Stefan Hajnoczi
2014-03-05 20:51 ` [Qemu-devel] [PATCH v3 3/5] qom: make QOM link property unref optional Stefan Hajnoczi
2014-03-05 20:51 ` [Qemu-devel] [PATCH v3 4/5] qom: add check() argument to object_property_add_link() Stefan Hajnoczi
2014-03-05 20:51 ` [Qemu-devel] [PATCH v3 5/5] virtio-rng: avoid default_backend refcount leak Stefan Hajnoczi
2014-03-18 12:27 ` [Qemu-devel] [PATCH v3 0/5] qom: link property fixes Stefan Hajnoczi
2014-03-18 12:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394052684-14362-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).