From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJZZ-0004V0-KW for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:41:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLJZT-0002az-L6 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:41:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJZT-0002ar-CP for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:41:47 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25LfjFn024493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 16:41:46 -0500 From: Max Reitz Date: Wed, 5 Mar 2014 22:41:36 +0100 Message-Id: <1394055700-5988-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1394055700-5988-1-git-send-email-mreitz@redhat.com> References: <1394055700-5988-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] block: Keep "filename" option after parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz Currently, bdrv_file_open() always removes the "filename" option from the options QDict after bdrv_parse_filename() has been (successfully) called. However, for drivers with bdrv_needs_filename, it makes more sense for bdrv_parse_filename() to overwrite the "filename" option and for bdrv_file_open() to fetch the filename from there. Since there currently are no drivers that implement bdrv_parse_filename() and have bdrv_needs_filename set, this does not change current behavior. Signed-off-by: Max Reitz --- block.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index f01b91c..845cbfb 100644 --- a/block.c +++ b/block.c @@ -1017,7 +1017,12 @@ static int bdrv_file_open(BlockDriverState *bs, const char *filename, ret = -EINVAL; goto fail; } - qdict_del(*options, "filename"); + + if (!drv->bdrv_needs_filename) { + qdict_del(*options, "filename"); + } else { + filename = qdict_get_str(*options, "filename"); + } } if (!drv->bdrv_file_open) { -- 1.9.0