From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLUMU-0005Q1-C5 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 04:13:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLUMN-0004hd-4j for qemu-devel@nongnu.org; Thu, 06 Mar 2014 04:13:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLUMM-0004hV-So for qemu-devel@nongnu.org; Thu, 06 Mar 2014 04:12:59 -0500 From: Markus Armbruster Date: Thu, 6 Mar 2014 10:12:53 +0100 Message-Id: <1394097173-14432-3-git-send-email-armbru@redhat.com> In-Reply-To: <1394097173-14432-1-git-send-email-armbru@redhat.com> References: <1394097173-14432-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/2] qdev-monitor-test: Don't test human-readable error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: afaerber@suse.de, stefanha@redhat.com Test the error class instead. Expecting a specific message is fragile. In fact, it broke once already, in commit 75884af. Restore the test of error member "class" dropped there, and drop the test of error member "desc". There are no other tests of "desc" as far as I can tell. Signed-off-by: Markus Armbruster --- tests/qdev-monitor-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c index eefaab8..e20ffd6 100644 --- a/tests/qdev-monitor-test.c +++ b/tests/qdev-monitor-test.c @@ -32,9 +32,7 @@ static void test_device_add(void) "}}"); g_assert(response); error = qdict_get_qdict(response, "error"); - g_assert_cmpstr(qdict_get_try_str(error, "desc"), - ==, - "Device needs media, but drive is empty"); + g_assert_cmpstr(qdict_get_try_str(error, "class"), ==, "GenericError"); QDECREF(response); /* Delete the drive */ -- 1.8.1.4