From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLaTm-00046R-Hd for qemu-devel@nongnu.org; Thu, 06 Mar 2014 10:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLaTf-0001uc-CR for qemu-devel@nongnu.org; Thu, 06 Mar 2014 10:45:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLaTf-0001uT-0S for qemu-devel@nongnu.org; Thu, 06 Mar 2014 10:44:55 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s26FiYRp001628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Mar 2014 10:44:37 -0500 From: Kevin Wolf Date: Thu, 6 Mar 2014 16:44:27 +0100 Message-Id: <1394120669-4675-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1394120669-4675-1-git-send-email-kwolf@redhat.com> References: <1394120669-4675-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] blockdev: Fail blockdev-add with encrypted images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com Encrypted images need a password before they can be used, and we don't want blockdev-add to create BDSes that aren't fully initialised. So for now simply forbid encrypted images; we can come back to it later if we need the functionality. Signed-off-by: Kevin Wolf --- blockdev.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 357f760..561cb81 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2266,6 +2266,7 @@ void qmp_block_job_complete(const char *device, Error **errp) void qmp_blockdev_add(BlockdevOptions *options, Error **errp) { QmpOutputVisitor *ov = qmp_output_visitor_new(); + DriveInfo *dinfo; QObject *obj; QDict *qdict; Error *local_err = NULL; @@ -2301,12 +2302,18 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp) qdict_flatten(qdict); - blockdev_init(NULL, qdict, &local_err); + dinfo = blockdev_init(NULL, qdict, &local_err); if (local_err) { error_propagate(errp, local_err); goto fail; } + if (bdrv_key_required(dinfo->bdrv)) { + drive_uninit(dinfo); + error_setg(errp, "blockdev-add doesn't support encrypted devices"); + goto fail; + } + fail: qmp_output_visitor_cleanup(ov); } -- 1.8.1.4