From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLrE0-0002Gb-RD for qemu-devel@nongnu.org; Fri, 07 Mar 2014 04:38:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLrDn-000884-BG for qemu-devel@nongnu.org; Fri, 07 Mar 2014 04:37:52 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:40174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLrDm-00087a-HZ for qemu-devel@nongnu.org; Fri, 07 Mar 2014 04:37:39 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 7 Mar 2014 19:37:35 +1000 From: Mark Wu Date: Fri, 7 Mar 2014 17:37:25 +0800 Message-Id: <1394185045-24868-2-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1394185045-24868-1-git-send-email-wudxw@linux.vnet.ibm.com> References: <1394185045-24868-1-git-send-email-wudxw@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v2 2/2] Fix return value of vga initlization on ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: nikunj@linux.vnet.ibm.com, agraf@suse.de, Mark Wu , aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_init should return true if it's told that the vga will be initialized in flow of the generic devices initialization. This patch also makes two cleanups: 1. skip initialization for VGA_NONE 2. remove the useless 'break' Signed-off-by: Mark Wu --- hw/ppc/spapr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 93d02c1..4d0ac56 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -765,13 +765,15 @@ static int spapr_vga_init(PCIBus *pci_bus) { switch (vga_interface_type) { case VGA_NONE: + return false; + case VGA_DEVICE: + return true; case VGA_STD: return pci_vga_init(pci_bus) != NULL; default: fprintf(stderr, "This vga model is not supported," "currently it only supports -vga std\n"); exit(0); - break; } } -- 1.8.4.2