From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM35r-0002W4-UW for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WM35q-0005tS-Ti for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:18:15 -0500 Received: from qemu.weilnetz.de ([2a03:4000:2:362::1]:40274 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM35q-0005tC-Ms for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:18:14 -0500 From: Stefan Weil Date: Fri, 7 Mar 2014 23:17:45 +0100 Message-Id: <1394230667-17037-4-git-send-email-sw@weilnetz.de> In-Reply-To: <1394230667-17037-1-git-send-email-sw@weilnetz.de> References: <1394230667-17037-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH v2 3/5] w32: Reduce dependencies in sysemu/os-win32.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, stefanha@redhat.com, Stefan Weil , Max Filippov , Anthony Liguori , pbonzini@redhat.com Most *.o files depend on that file, but many of them don't need windows.h or winsock2.h. sysemu/os-win32.h only needs some definitions from winerror.h. After that change, all files which depend on windows.h or winsock2.h and which no longer get it indirectly have to be fixed. Use qemu/sockets.h to get winsock2.h. Add comments to all those new include statements. The modification in ui/vnc-enc-tight.c is needed temporarily and will be removed again in the following patch. Cc: Anthony Liguori Cc: Max Filippov Signed-off-by: Stefan Weil --- coroutine-win32.c | 1 + include/net/eth.h | 2 +- include/sysemu/os-win32.h | 3 +-- target-xtensa/xtensa-semi.c | 1 + ui/vnc-enc-tight.c | 1 + 5 files changed, 5 insertions(+), 3 deletions(-) diff --git a/coroutine-win32.c b/coroutine-win32.c index edc1f72..4678d17 100644 --- a/coroutine-win32.c +++ b/coroutine-win32.c @@ -24,6 +24,7 @@ #include "qemu-common.h" #include "block/coroutine_int.h" +#include "qemu/winapi.h" /* CreateFiber, ... */ typedef struct { diff --git a/include/net/eth.h b/include/net/eth.h index b3273b8..f5a369f 100644 --- a/include/net/eth.h +++ b/include/net/eth.h @@ -26,10 +26,10 @@ #ifndef QEMU_ETH_H #define QEMU_ETH_H -#include #include #include "qemu/bswap.h" #include "qemu/iov.h" +#include "qemu/sockets.h" /* u_short */ #define ETH_ALEN 6 diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index 1d6494a..d625612 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -26,8 +26,7 @@ #ifndef QEMU_OS_WIN32_H #define QEMU_OS_WIN32_H -#include "qemu/winapi.h" -#include +#include /* WSAECONNREFUSED, ... */ /* Workaround for older versions of MinGW. */ #ifndef ECONNREFUSED diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c index 424253d..ad06f99 100644 --- a/target-xtensa/xtensa-semi.c +++ b/target-xtensa/xtensa-semi.c @@ -32,6 +32,7 @@ #include "cpu.h" #include "helper.h" #include "qemu/log.h" +#include "qemu/sockets.h" /* select */ enum { TARGET_SYS_exit = 1, diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index e6966ae..94bb002 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -31,6 +31,7 @@ /* This needs to be before jpeglib.h line because of conflict with INT32 definitions between jmorecfg.h (included by jpeglib.h) and Win32 basetsd.h (included by windows.h). */ +#include "qemu/winapi.h" /* TODO: workaround, remove */ #include "qemu-common.h" #ifdef CONFIG_VNC_PNG -- 1.7.10.4