qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>, Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 9/9] ui/vnc: disable adaptive update calculations if not needed
Date: Mon, 10 Mar 2014 13:49:13 +0100	[thread overview]
Message-ID: <1394455753-13783-10-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1394455753-13783-1-git-send-email-kraxel@redhat.com>

From: Peter Lieven <pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/vnc.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ui/vnc.c b/ui/vnc.c
index 25e4380..9c84b3e 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3150,7 +3150,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)
             acl = 1;
 #endif
         } else if (strncmp(options, "lossy", 5) == 0) {
+#ifdef CONFIG_VNC_JPEG
             vs->lossy = true;
+#endif
         } else if (strncmp(options, "non-adaptive", 12) == 0) {
             vs->non_adaptive = true;
         } else if (strncmp(options, "share=", 6) == 0) {
@@ -3167,6 +3169,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)
         }
     }
 
+    /* adaptive updates are only used with tight encoding and
+     * if lossy updates are enabled so we can disable all the
+     * calculations otherwise */
+    if (!vs->lossy) {
+        vs->non_adaptive = true;
+    }
+
 #ifdef CONFIG_VNC_TLS
     if (acl && x509 && vs->tls.x509verify) {
         if (!(vs->tls.acl = qemu_acl_init("vnc.x509dname"))) {
-- 
1.8.3.1

  parent reply	other threads:[~2014-03-10 12:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 12:49 [Qemu-devel] [PULL 0/9] vnc patches Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 1/9] vnc: Fix tight_detect_smooth_image() for lossless case Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 2/9] vnc: Fix qemu crashed when vnc client disconnect suddenly Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 3/9] vnc: fix use-after-free in vnc_update_client_sync Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 4/9] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 5/9] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 6/9] ui/vnc: optimize dirty bitmap tracking Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 7/9] ui/vnc: optimize clearing in find_and_clear_dirty_height() Gerd Hoffmann
2014-03-10 12:49 ` [Qemu-devel] [PULL 8/9] ui/vnc: optimize setting in vnc_dpy_update() Gerd Hoffmann
2014-03-10 12:49 ` Gerd Hoffmann [this message]
2014-03-11 11:37 ` [Qemu-devel] [PULL 0/9] vnc patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394455753-13783-10-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).