From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMze7-0001Du-O3 for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMze1-0000df-M9 for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:49:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMze1-0000da-Dq for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:49:25 -0400 From: Gerd Hoffmann Date: Mon, 10 Mar 2014 13:49:05 +0100 Message-Id: <1394455753-13783-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1394455753-13783-1-git-send-email-kraxel@redhat.com> References: <1394455753-13783-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/9] vnc: Fix tight_detect_smooth_image() for lossless case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Anthony Liguori , Gerd Hoffmann From: Markus Armbruster VncTight member uint8_t quality is either (uint8_t)-1 for lossless or less than 10 for lossy. tight_detect_smooth_image() first promotes it to int, then compares with -1. Always unequal, so we always execute the lossy code. Reads beyond tight_conf[] and returns crap when quality is actually lossless. Compare to (uint8_t)-1 instead, like we do elsewhere. Spotted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc-enc-tight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index e6966ae..59b59c0 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -330,7 +330,7 @@ tight_detect_smooth_image(VncState *vs, int w, int h) } else { errors = tight_detect_smooth_image16(vs, w, h); } - if (quality != -1) { + if (quality != (uint8_t)-1) { return (errors < tight_conf[quality].jpeg_threshold); } return (errors < tight_conf[compression].gradient_threshold); -- 1.8.3.1