qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, patches@linaro.org
Subject: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit
Date: Mon, 10 Mar 2014 19:10:39 +0000	[thread overview]
Message-ID: <1394478649-9453-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1394478649-9453-1-git-send-email-peter.maydell@linaro.org>

Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/pci/pci_host.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
index 77c7d1f..2c17916 100644
--- a/hw/pci/pci_host.c
+++ b/hw/pci/pci_host.c
@@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
 {
     PCIHostState *s = opaque;
     uint32_t val;
-    if (!(s->config_reg & (1 << 31)))
+    if (!(s->config_reg & (1u << 31))) {
         return 0xffffffff;
+    }
     val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
     PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
                 addr, len, val);
-- 
1.9.0

  parent reply	other threads:[~2014-03-10 19:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 19:10 [Qemu-devel] [PATCH 00/12] Avoid shifting left into sign bit Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 01/12] target-i386: " Peter Maydell
2014-03-10 21:57   ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic Peter Maydell
2014-03-10 19:39   ` Stefan Weil
2014-03-10 21:56   ` Michael S. Tsirkin
2014-03-10 19:10 ` Peter Maydell [this message]
2014-03-10 20:03   ` [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit Stefan Weil
2014-03-10 21:46     ` Michael S. Tsirkin
2014-03-10 21:58   ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 04/12] hw/i386/acpi_build.c: " Peter Maydell
2014-03-10 21:56   ` Michael S. Tsirkin
2014-03-10 19:10 ` [Qemu-devel] [PATCH 05/12] target-mips: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 06/12] hw/usb/hcd-ohci.c: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 07/12] hw/intc/openpic: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 08/12] hw/ppc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 09/12] tests/libqos/pci-pc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 10/12] hw/intc/slavio_intctl: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 11/12] hw/intc/xilinx_intc: " Peter Maydell
2014-03-10 19:10 ` [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: " Peter Maydell
2014-03-10 21:59   ` Michael S. Tsirkin
2014-03-14 16:45     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-10 22:00 ` [Qemu-devel] [PATCH 00/12] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394478649-9453-4-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).