From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 3/6] configure: don't modify .status on error
Date: Tue, 11 Mar 2014 14:32:27 +0200 [thread overview]
Message-ID: <1394537675-30618-4-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1394537675-30618-1-git-send-email-mst@redhat.com>
./configure --help
make
will try to re-run configure with --help
which isn't what was intended.
The reason is that config.status was written
even on configure error.
Defer writing config.status until configure
has completed successfully.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/configure b/configure
index 8689435..3ae57d7 100755
--- a/configure
+++ b/configure
@@ -31,19 +31,6 @@ printf " '%s'" "$0" "$@" >> config.log
echo >> config.log
echo "#" >> config.log
-# Save the configure command line for later reuse.
-cat <<EOD >config.status
-#!/bin/sh
-# Generated by configure.
-# Run this file to recreate the current configuration.
-# Compiler output produced by configure, useful for debugging
-# configure, is in config.log if it exists.
-EOD
-printf "exec" >>config.status
-printf " '%s'" "$0" "$@" >>config.status
-echo >>config.status
-chmod +x config.status
-
error_exit() {
echo
echo "ERROR: $1"
@@ -5136,3 +5123,17 @@ done
if test "$docs" = "yes" ; then
mkdir -p QMP
fi
+
+# Save the configure command line for later reuse.
+cat <<EOD >config.status
+#!/bin/sh
+# Generated by configure.
+# Run this file to recreate the current configuration.
+# Compiler output produced by configure, useful for debugging
+# configure, is in config.log if it exists.
+EOD
+printf "exec" >>config.status
+printf " '%s'" "$0" "$@" >>config.status
+echo >>config.status
+chmod +x config.status
+
--
MST
next prev parent reply other threads:[~2014-03-11 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:32 [Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes Michael S. Tsirkin
2014-03-11 12:32 ` [Qemu-devel] [PULL 1/6] loader: rename in_ram/has_mr Michael S. Tsirkin
2014-03-11 12:32 ` [Qemu-devel] [PULL 2/6] pc: avoid duplicate names for ROM MRs Michael S. Tsirkin
2014-03-11 12:32 ` Michael S. Tsirkin [this message]
2014-03-11 12:32 ` [Qemu-devel] [PULL 4/6] q35: Correct typo BRDIGE -> BRIDGE Michael S. Tsirkin
2014-03-11 12:32 ` [Qemu-devel] [PULL 5/6] acpi-build: don't access unaligned addresses Michael S. Tsirkin
2014-03-11 12:32 ` [Qemu-devel] [PULL 6/6] acpi-test: update expected SSDT files Michael S. Tsirkin
2014-03-12 10:49 ` [Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394537675-30618-4-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).