From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, armbru@redhat.com,
aliguori@amazon.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization
Date: Tue, 11 Mar 2014 14:24:47 +0200 [thread overview]
Message-ID: <1394540689-26672-1-git-send-email-marcel.a@redhat.com> (raw)
V2 -> V3:
Addressed Eric Blake's review:
- Corrected a typo.
- Replace the commented Makefile part
V1 -> V2:
Addressed Stefan Hajnoczi's review:
- Dropped qtest_state_valid API
- Moved socket options in socket_accept.
'socket_accept' waits for Qemu to initialize its unix socket.
If Qemu encounters an error during command line parsing,
it can exit before initializing the communication channel.
Using a timeout for sockets fixes the issue, but is not
enough. We need to know which test from check-qtest-*
fails.
We tweak the Makefile to produce per-test output.
The effect is that the output will grow, but we will know
which qtest failed. This helps when an assert is made on
other code and not in the test itself.
Marcel Apfelbaum (1):
tests/libqtest: Fix possible deadlock in qtest initialization
Stefan Hajnoczi (1):
tests: Tweak the Makefile to produce per-test output.
tests/Makefile | 2 +-
tests/libqtest.c | 11 +++++++++--
2 files changed, 10 insertions(+), 3 deletions(-)
--
1.8.3.1
next reply other threads:[~2014-03-11 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:24 Marcel Apfelbaum [this message]
2014-03-11 12:24 ` [Qemu-devel] [PATCH V3 1/2] tests/libqtest: Fix possible deadlock in qtest initialization Marcel Apfelbaum
2014-03-11 12:24 ` [Qemu-devel] [PATCH V3 2/2] tests: Tweak the Makefile to produce per-test output Marcel Apfelbaum
2014-03-11 12:32 ` [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394540689-26672-1-git-send-email-marcel.a@redhat.com \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).