From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLkY-0001Ay-Ty for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNLkS-0004WF-Nd for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:25:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLkS-0004Vz-0B for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:25:32 -0400 From: Marcel Apfelbaum Date: Tue, 11 Mar 2014 14:24:47 +0200 Message-Id: <1394540689-26672-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, armbru@redhat.com, aliguori@amazon.com, afaerber@suse.de V2 -> V3: Addressed Eric Blake's review: - Corrected a typo. - Replace the commented Makefile part V1 -> V2: Addressed Stefan Hajnoczi's review: - Dropped qtest_state_valid API - Moved socket options in socket_accept. 'socket_accept' waits for Qemu to initialize its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. Using a timeout for sockets fixes the issue, but is not enough. We need to know which test from check-qtest-* fails. We tweak the Makefile to produce per-test output. The effect is that the output will grow, but we will know which qtest failed. This helps when an assert is made on other code and not in the test itself. Marcel Apfelbaum (1): tests/libqtest: Fix possible deadlock in qtest initialization Stefan Hajnoczi (1): tests: Tweak the Makefile to produce per-test output. tests/Makefile | 2 +- tests/libqtest.c | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) -- 1.8.3.1