qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: qemu-devel@nongnu.org
Cc: agraf@suse.de, gsomlo@gmail.com, armbru@redhat.com,
	alex.williamson@redhat.com, kevin@koconnor.net,
	kraxel@redhat.com, lersek@redhat.com
Subject: [Qemu-devel] [v2 PATCH 12/13] SMBIOS: Build full type 20 tables
Date: Tue, 11 Mar 2014 11:16:28 -0400	[thread overview]
Message-ID: <1394550989-693-13-git-send-email-somlo@cmu.edu> (raw)
In-Reply-To: <1394550989-693-1-git-send-email-somlo@cmu.edu>

From: "Gabriel L. Somlo" <somlo@cmu.edu>

Build full smbios type 20 (memory device mapped address) tables,
and make them available via fw_cfg.

Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
---
 hw/i386/smbios.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index c9cd295..9cf29d3 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -566,6 +566,23 @@ static void smbios_build_type_19_table(unsigned instance,
     SMBIOS_BUILD_TABLE_POST;
 }
 
+static void smbios_build_type_20_table(unsigned instance,
+                                       unsigned dev_hndl, unsigned array_hndl,
+                                       unsigned start_kb, unsigned size_kb)
+{
+    SMBIOS_BUILD_TABLE_PRE(20, 0x1400 + instance, true); /* required */
+
+    t->starting_address = start_kb;
+    t->ending_address = start_kb + size_kb - 1;
+    t->memory_device_handle = 0x1100 + dev_hndl; /* Type 17 (Memory Device) */
+    t->memory_array_mapped_address_handle = 0x1300 + array_hndl; /* Type 19 */
+    t->partition_row_position = 1; /* hardcoded in SeaBIOS */
+    t->interleave_position = 0; /* Not interleaved */
+    t->interleaved_data_depth = 0; /* Not interleaved */
+
+    SMBIOS_BUILD_TABLE_POST;
+}
+
 #define SMBIOS_SET_DEFAULT(field, value)                                  \
     if (!field) {                                                         \
         field = value;                                                    \
@@ -629,8 +646,20 @@ uint8_t *smbios_get_table(size_t *length)
             smbios_build_type_17_table(i, size_mb);
         }
         smbios_build_type_19_table(0, 0, smbios_below_4g_ram >> 10);
+        smbios_build_type_20_table(0, 0, 0, 0, smbios_below_4g_ram >> 10);
         if (smbios_above_4g_ram) {
+            uint32_t start_mb = 4096, size_mb, j;
             smbios_build_type_19_table(1, 4 << 20, smbios_above_4g_ram >> 10);
+            for (j = 1, i = 0; i < memdev_count; i++, j++) {
+                size_mb = (i == memdev_count - 1) ?
+                          ((ram_size_mb - 1) & 0x3FFF) + 1 : 0x4000;
+                if (i == 0) {
+                    size_mb -= smbios_below_4g_ram >> 20;
+                }
+                smbios_build_type_20_table(j, i, 1,
+                                           start_mb << 10, size_mb << 10);
+                start_mb += size_mb;
+            }
         }
         smbios_validate_table();
         smbios_immutable = true;
-- 
1.8.1.4

  parent reply	other threads:[~2014-03-11 15:20 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 16:56 [Qemu-devel] SMBIOS (Set of 10 patches) Gabriel L. Somlo
2014-03-10 17:55 ` Eric Blake
2014-03-10 18:17   ` Gabriel L. Somlo
2014-03-10 18:31     ` Gabriel L. Somlo
2014-03-10 19:14     ` Eric Blake
2014-03-10 19:22       ` Eric Blake
2014-03-10 19:31   ` Eric Blake
2014-03-11 10:03 ` Gerd Hoffmann
2014-03-11 13:27   ` Kevin O'Connor
2014-03-12  8:31     ` Gerd Hoffmann
2014-03-11 15:16   ` [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 01/13] SMBIOS: Update all table definitions to smbios spec v2.3 Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 02/13] SMBIOS: Rename smbios_set_type1_defaults() for more general use Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 03/13] SMBIOS: Use macro to set smbios defaults Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 04/13] SMBIOS: Use bitmaps to check for smbios table collisions Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 05/13] SMBIOS: Add code to build full smbios tables; build type 2 table Gabriel L. Somlo
2014-03-11 16:28       ` [Qemu-devel] [v3 " Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 06/13] SMBIOS: Build full tables for types 0 and 1 Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 07/13] SMBIOS: Remove unused code for passing individual fields to bios Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 08/13] SMBIOS: Build full type 3 table Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 09/13] SMBIOS: Build full type 4 tables Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 10/13] SMBIOS: Build full smbios v2.3 compliant type 16 and 17 tables Gabriel L. Somlo
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables Gabriel L. Somlo
2014-03-12  8:27       ` Gerd Hoffmann
2014-03-12 13:05         ` Gabriel L. Somlo
2014-03-12 13:24           ` Gerd Hoffmann
2014-03-12 14:44             ` Gabriel L. Somlo
2014-03-12 15:51               ` Gerd Hoffmann
2014-03-12 16:45             ` Gabriel L. Somlo
2014-03-12 18:04             ` Gabriel L. Somlo
2014-03-12 18:17               ` Gabriel L. Somlo
2014-03-11 15:16     ` Gabriel L. Somlo [this message]
2014-03-11 15:16     ` [Qemu-devel] [v2 PATCH 13/13] SMBIOS: Build full tables for type 32 and 127 Gabriel L. Somlo
2014-03-11 15:46     ` [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU Kevin O'Connor
2014-03-11 16:58       ` Gabriel L. Somlo
2014-03-12  8:20         ` Gerd Hoffmann
2014-03-12 16:39           ` [Qemu-devel] [v3 " Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 01/13] SMBIOS: Rename smbios_set_type1_defaults() for more general use Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 02/13] SMBIOS: Use macro to set smbios defaults Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 03/13] SMBIOS: Use bitmaps to check for smbios table collisions Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 04/13] SMBIOS: Add code to build full smbios tables; build type 2 table Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 05/13] SMBIOS: Build full tables for types 0 and 1 Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 06/13] SMBIOS: Remove unused code for passing individual fields to bios Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 07/13] SMBIOS: Build full type 3 table Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 08/13] SMBIOS: Build full type 4 tables Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 09/13] SMBIOS: Build full smbios type 16 and 17 tables Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 10/13] SMBIOS: Build full type 19 tables Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 11/13] SMBIOS: Build full type 20 tables Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 12/13] SMBIOS: Build full tables for type 32 and 127 Gabriel L. Somlo
2014-03-12 16:40             ` [Qemu-devel] [v3 PATCH 13/13] SMBIOS: Update all table definitions to smbios spec v2.3 Gabriel L. Somlo
2014-03-12 16:48             ` [Qemu-devel] [v3 PATCH 00/13] SMBIOS: build full tables in QEMU Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394550989-693-13-git-send-email-somlo@cmu.edu \
    --to=gsomlo@gmail.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).