From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNc65-0002zj-EJ for qemu-devel@nongnu.org; Wed, 12 Mar 2014 01:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNc5t-0005K1-Ho for qemu-devel@nongnu.org; Wed, 12 Mar 2014 01:52:57 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:45435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNc5s-0005Hs-HK for qemu-devel@nongnu.org; Wed, 12 Mar 2014 01:52:45 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Mar 2014 15:52:39 +1000 From: Alexey Kardashevskiy Date: Wed, 12 Mar 2014 16:52:20 +1100 Message-Id: <1394603550-11556-2-git-send-email-aik@ozlabs.ru> In-Reply-To: <1394603550-11556-1-git-send-email-aik@ozlabs.ru> References: <1394603550-11556-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH v5 01/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: Alexey Kardashevskiy , Alexander Graf , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson From: David Gibson At the moment, most AddressSpace objects last as long as the guest system in practice, but that could well change in future. In addition, for VFIO we will be introducing some private per-AdressSpace information, which must be disposed of before the AddressSpace itself is destroyed. To reduce the chances of subtle bugs in this area, this patch adds asssertions to ensure that when an AddressSpace is destroyed, there are no remaining MemoryListeners using that AS as a filter. Signed-off-by: David Gibson Signed-off-by: Alexey Kardashevskiy --- memory.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/memory.c b/memory.c index 3f1df23..678661e 100644 --- a/memory.c +++ b/memory.c @@ -1722,12 +1722,19 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name) void address_space_destroy(AddressSpace *as) { + MemoryListener *listener; + /* Flush out anything from MemoryListeners listening in on this */ memory_region_transaction_begin(); as->root = NULL; memory_region_transaction_commit(); QTAILQ_REMOVE(&address_spaces, as, address_spaces_link); address_space_destroy_dispatch(as); + + QTAILQ_FOREACH(listener, &memory_listeners, link) { + assert(listener->address_space_filter != as); + } + flatview_unref(as->current_map); g_free(as->name); g_free(as->ioeventfds); -- 1.8.4.rc4