From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,
alex.williamson@redhat.com, Kevin O'Connor <kevin@koconnor.net>,
lersek@redhat.com
Subject: Re: [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU
Date: Wed, 12 Mar 2014 09:20:54 +0100 [thread overview]
Message-ID: <1394612454.17393.16.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140311165819.GX17184@ERROL.INI.CMU.EDU>
On Di, 2014-03-11 at 12:58 -0400, Gabriel L. Somlo wrote:
> On Tue, Mar 11, 2014 at 11:46:17AM -0400, Kevin O'Connor wrote:
> > I would suggest being "bug for bug" compatible in the first set of
> > patches, and then add patches on top to add the additional
> > functionality. Just my 2 cents.
Makes sense indeed.
> With the patch enclosed at the end of this email, I can get it
> down to this:
Just move patch #1 to the end of the series. So we first switch over
table by table, generating output identical to current seabios, then go
fix/improve things on top of that. That way it'll be easier to bisect
problems in case any show up.
cheers,
Gerd
next prev parent reply other threads:[~2014-03-12 8:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 16:56 [Qemu-devel] SMBIOS (Set of 10 patches) Gabriel L. Somlo
2014-03-10 17:55 ` Eric Blake
2014-03-10 18:17 ` Gabriel L. Somlo
2014-03-10 18:31 ` Gabriel L. Somlo
2014-03-10 19:14 ` Eric Blake
2014-03-10 19:22 ` Eric Blake
2014-03-10 19:31 ` Eric Blake
2014-03-11 10:03 ` Gerd Hoffmann
2014-03-11 13:27 ` Kevin O'Connor
2014-03-12 8:31 ` Gerd Hoffmann
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 01/13] SMBIOS: Update all table definitions to smbios spec v2.3 Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 02/13] SMBIOS: Rename smbios_set_type1_defaults() for more general use Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 03/13] SMBIOS: Use macro to set smbios defaults Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 04/13] SMBIOS: Use bitmaps to check for smbios table collisions Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 05/13] SMBIOS: Add code to build full smbios tables; build type 2 table Gabriel L. Somlo
2014-03-11 16:28 ` [Qemu-devel] [v3 " Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 06/13] SMBIOS: Build full tables for types 0 and 1 Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 07/13] SMBIOS: Remove unused code for passing individual fields to bios Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 08/13] SMBIOS: Build full type 3 table Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 09/13] SMBIOS: Build full type 4 tables Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 10/13] SMBIOS: Build full smbios v2.3 compliant type 16 and 17 tables Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables Gabriel L. Somlo
2014-03-12 8:27 ` Gerd Hoffmann
2014-03-12 13:05 ` Gabriel L. Somlo
2014-03-12 13:24 ` Gerd Hoffmann
2014-03-12 14:44 ` Gabriel L. Somlo
2014-03-12 15:51 ` Gerd Hoffmann
2014-03-12 16:45 ` Gabriel L. Somlo
2014-03-12 18:04 ` Gabriel L. Somlo
2014-03-12 18:17 ` Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 12/13] SMBIOS: Build full type 20 tables Gabriel L. Somlo
2014-03-11 15:16 ` [Qemu-devel] [v2 PATCH 13/13] SMBIOS: Build full tables for type 32 and 127 Gabriel L. Somlo
2014-03-11 15:46 ` [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU Kevin O'Connor
2014-03-11 16:58 ` Gabriel L. Somlo
2014-03-12 8:20 ` Gerd Hoffmann [this message]
2014-03-12 16:39 ` [Qemu-devel] [v3 " Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 01/13] SMBIOS: Rename smbios_set_type1_defaults() for more general use Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 02/13] SMBIOS: Use macro to set smbios defaults Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 03/13] SMBIOS: Use bitmaps to check for smbios table collisions Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 04/13] SMBIOS: Add code to build full smbios tables; build type 2 table Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 05/13] SMBIOS: Build full tables for types 0 and 1 Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 06/13] SMBIOS: Remove unused code for passing individual fields to bios Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 07/13] SMBIOS: Build full type 3 table Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 08/13] SMBIOS: Build full type 4 tables Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 09/13] SMBIOS: Build full smbios type 16 and 17 tables Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 10/13] SMBIOS: Build full type 19 tables Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 11/13] SMBIOS: Build full type 20 tables Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 12/13] SMBIOS: Build full tables for type 32 and 127 Gabriel L. Somlo
2014-03-12 16:40 ` [Qemu-devel] [v3 PATCH 13/13] SMBIOS: Update all table definitions to smbios spec v2.3 Gabriel L. Somlo
2014-03-12 16:48 ` [Qemu-devel] [v3 PATCH 00/13] SMBIOS: build full tables in QEMU Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394612454.17393.16.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=gsomlo@gmail.com \
--cc=kevin@koconnor.net \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).