From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNePb-0003kA-W6 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:21:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNePW-0001RK-1d for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:21:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNePV-0001RF-PA for qemu-devel@nongnu.org; Wed, 12 Mar 2014 04:21:09 -0400 Message-ID: <1394612454.17393.16.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 12 Mar 2014 09:20:54 +0100 In-Reply-To: <20140311165819.GX17184@ERROL.INI.CMU.EDU> References: <1394532186.22422.24.camel@nilsson.home.kraxel.org> <1394550989-693-1-git-send-email-somlo@cmu.edu> <20140311154617.GA5938@morn.localdomain> <20140311165819.GX17184@ERROL.INI.CMU.EDU> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, alex.williamson@redhat.com, Kevin O'Connor , lersek@redhat.com On Di, 2014-03-11 at 12:58 -0400, Gabriel L. Somlo wrote: > On Tue, Mar 11, 2014 at 11:46:17AM -0400, Kevin O'Connor wrote: > > I would suggest being "bug for bug" compatible in the first set of > > patches, and then add patches on top to add the additional > > functionality. Just my 2 cents. Makes sense indeed. > With the patch enclosed at the end of this email, I can get it > down to this: Just move patch #1 to the end of the series. So we first switch over table by table, generating output identical to current seabios, then go fix/improve things on top of that. That way it'll be easier to bisect problems in case any show up. cheers, Gerd