From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WNfO6-0003aV-94
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:23:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WNfO1-0005cX-7i
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:23:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51288)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WNfO1-0005cG-0L
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 05:23:41 -0400
Message-ID: <1394612838.17393.19.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 12 Mar 2014 09:27:18 +0100
In-Reply-To: <1394550989-693-12-git-send-email-somlo@cmu.edu>
References: <1394532186.22422.24.camel@nilsson.home.kraxel.org>
	<1394550989-693-1-git-send-email-somlo@cmu.edu>
	<1394550989-693-12-git-send-email-somlo@cmu.edu>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, alex.williamson@redhat.com, kevin@koconnor.net, lersek@redhat.com

On Di, 2014-03-11 at 11:16 -0400, Gabriel L. Somlo wrote:
> From: "Gabriel L. Somlo" <somlo@cmu.edu>
> 
> Build full smbios type 19 (memory array mapped address) tables,
> and make them available via fw_cfg


> +        smbios_build_type_19_table(0, 0, smbios_below_4g_ram >> 10);
> +        if (smbios_above_4g_ram) {
> +            smbios_build_type_19_table(1, 4 << 20, smbios_above_4g_ram >> 10);
> +        }

I think we should just use e820_table (see pc.c) here.  Loop over it and
add a type 19 table for each ram region in there.

cheers,
  Gerd