[Qemu-devel] [PATCH 7.0 qemu-kvm 0/1] QMP: Relax __com.redhat_drive_add parameter checking

[Qemu-devel] [PATCH 7.0 qemu-kvm 0/1] QMP: Relax __com.redhat_drive_add parameter checking

[Markus Armbruster]

Bugzilla: 1057471
Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7146335
Upstream-status: RHEL-only, see commit message

Markus Armbruster (1):
  QMP: Relax __com.redhat_drive_add parameter checking

 device-hotplug.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

-- 
1.8.1.4

[Qemu-devel] [PATCH 7.0 qemu-kvm 1/1] QMP: Relax __com.redhat_drive_add parameter checking

[Markus Armbruster]

Many new features are unavailable with this command, because its
parameter checking is overly restrictive.  Relax it.

The command was forward-ported from RHEL-6 (commit 75ad257).  It
provides access to drive_init() via QMP with the parameters restricted
to a subset of the ones recognized by drive_init().  We did that
because some parameters make sense only when configuring a frontend in
addition to a backend, and the command doesn't do that.

The parameter filtering is implemented as a whitelist.  The
forward-port neglected to update the whitelist for all the stuff that
has changed since RHEL-6.

Due to new features like driver-specific parameters, a whitelist is no
longer convenient.  Replace by a blacklist that contains exactly the
drive_init() parameters that are already filtered out on RHEL-6.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 device-hotplug.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/device-hotplug.c b/device-hotplug.c
index 20f6b7f..78a18f2 100644
--- a/device-hotplug.c
+++ b/device-hotplug.c
@@ -80,13 +80,8 @@ err:
 
 static void check_parm(const char *key, QObject *obj, void *opaque)
 {
-    static const char *valid_keys[] = {
-        "id", "cyls", "heads", "secs", "trans", "media", "snapshot",
-        "file", "cache", "aio", "format", "serial", "rerror", "werror",
-        "readonly", "copy-on-read",
-#ifdef CONFIG_BLOCK_IO_THROTTLING
-        "bps", "bps_rd", "bps_wr", "iops", "iops_rd", "iops_wr",
-#endif
+    static const char *unwanted_keys[] = {
+        "bus", "unit", "index", "if", "boot", "addr",
         NULL
 
     };
@@ -97,14 +92,14 @@ static void check_parm(const char *key, QObject *obj, void *opaque)
         return;
     }
 
-    for (p = valid_keys; *p; p++) {
+    for (p = unwanted_keys; *p; p++) {
         if (!strcmp(key, *p)) {
+            qerror_report(QERR_INVALID_PARAMETER, key);
+            *stopped = 1;
             return;
         }
     }
 
-    qerror_report(QERR_INVALID_PARAMETER, key);
-    *stopped = 1;
 }
 
 int simple_drive_add(Monitor *mon, const QDict *qdict, QObject **ret_data)
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH 7.0 qemu-kvm 1/1] QMP: Relax __com.redhat_drive_add parameter checking

[Markus Armbruster]

Ignore this one, please.  Multi-tasking while sending out patches
considered foolish, film at eleven.