From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNvmM-0000DG-MI for qemu-devel@nongnu.org; Wed, 12 Mar 2014 22:53:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNvmF-0004CK-OK for qemu-devel@nongnu.org; Wed, 12 Mar 2014 22:53:54 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 13 Mar 2014 03:53:33 +0100 Message-Id: <1394679213-1830-7-git-send-email-afaerber@suse.de> In-Reply-To: <1394679213-1830-1-git-send-email-afaerber@suse.de> References: <1394679213-1830-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL for-2.0-rc0 6/6] spapr-pci: Convert fprintf() to error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= , Alexander Graf From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day Signed-off-by: Andreas F=C3=A4rber --- hw/ppc/spapr_pci.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index f737493..3c54399 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -32,6 +32,7 @@ #include "exec/address-spaces.h" #include #include "trace.h" +#include "qemu/error-report.h" =20 #include "hw/pci/pci_bus.h" =20 @@ -292,7 +293,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAP= REnvironment *spapr, ret_intr_type =3D RTAS_TYPE_MSIX; break; default: - fprintf(stderr, "rtas_ibm_change_msi(%u) is not implemented\n", = func); + error_report("rtas_ibm_change_msi(%u) is not implemented", func)= ; rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR); return; } @@ -326,7 +327,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAP= REnvironment *spapr, /* Find a device number in the map to add or reuse the existing one = */ ndev =3D spapr_msicfg_find(phb, config_addr, true); if (ndev >=3D SPAPR_MSIX_MAX_DEVS || ndev < 0) { - fprintf(stderr, "No free entry for a new MSI device\n"); + error_report("No free entry for a new MSI device"); rtas_st(rets, 0, RTAS_OUT_HW_ERROR); return; } @@ -335,7 +336,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAP= REnvironment *spapr, /* Check if there is an old config and MSI number has not changed */ if (phb->msi_table[ndev].nvec && (req_num !=3D phb->msi_table[ndev].= nvec)) { /* Unexpected behaviour */ - fprintf(stderr, "Cannot reuse MSI config for device#%d", ndev); + error_report("Cannot reuse MSI config for device#%d", ndev); rtas_st(rets, 0, RTAS_OUT_HW_ERROR); return; } @@ -345,7 +346,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAP= REnvironment *spapr, irq =3D spapr_allocate_irq_block(req_num, false, ret_intr_type =3D=3D RTAS_TYPE_MS= I); if (irq < 0) { - fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev); + error_report("Cannot allocate MSIs for device#%d", ndev); rtas_st(rets, 0, RTAS_OUT_HW_ERROR); return; } --=20 1.8.4.5