From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOCXK-0000Xb-ID for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOCXE-0000uv-A5 for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:47:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39057 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOCXE-0000uo-3S for qemu-devel@nongnu.org; Thu, 13 Mar 2014 16:47:24 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 96AC375019 for ; Thu, 13 Mar 2014 20:47:23 +0000 (UTC) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 13 Mar 2014 21:47:13 +0100 Message-Id: <1394743636-23848-3-git-send-email-afaerber@suse.de> In-Reply-To: <1394743636-23848-1-git-send-email-afaerber@suse.de> References: <1394743636-23848-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL for-2.0 2/4] virtio-console-test: Test virtserialport as well List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= A test is only as good as its coverage - testing virtserialport in addition to virtconsole showed that commit 0399a3819b27083ba69b88a9baa9025facab85bd (virtio-console: QOM cast cleanup for VirtConsole) broke virtserialport. Acked-by: Richard W.M. Jones Signed-off-by: Andreas F=C3=A4rber --- tests/virtio-console-test.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tests/virtio-console-test.c b/tests/virtio-console-test.c index f98f5af2..6be96e8 100644 --- a/tests/virtio-console-test.c +++ b/tests/virtio-console-test.c @@ -13,8 +13,18 @@ #include "qemu/osdep.h" =20 /* Tests only initialization so far. TODO: Replace with functional tests= */ -static void pci_nop(void) +static void console_pci_nop(void) { + qtest_start("-device virtio-serial-pci,id=3Dvser0 " + "-device virtconsole,bus=3Dvser0.0"); + qtest_end(); +} + +static void serialport_pci_nop(void) +{ + qtest_start("-device virtio-serial-pci,id=3Dvser0 " + "-device virtserialport,bus=3Dvser0.0"); + qtest_end(); } =20 int main(int argc, char **argv) @@ -22,13 +32,10 @@ int main(int argc, char **argv) int ret; =20 g_test_init(&argc, &argv, NULL); - qtest_add_func("/virtio/console/pci/nop", pci_nop); + qtest_add_func("/virtio/console/pci/nop", console_pci_nop); + qtest_add_func("/virtio/serialport/pci/nop", serialport_pci_nop); =20 - qtest_start("-device virtio-serial-pci,id=3Dvser0 " - "-device virtconsole,bus=3Dvser0.0"); ret =3D g_test_run(); =20 - qtest_end(); - return ret; } --=20 1.8.4.5