From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WOOk2-0007Va-Tp
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:49:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WOOjw-0006Wb-Rn
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:49:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WOOjw-0006WQ-BN
	for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:49:20 -0400
Message-ID: <1394790493.5732.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 14 Mar 2014 10:48:13 +0100
In-Reply-To: <cover.1394738819.git.crobinso@redhat.com>
References: <cover.1394738819.git.crobinso@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Do, 2014-03-13 at 15:30 -0400, Cole Robinson wrote:
> First patch documents a configure option.
> Next 3 patches fix deprecation warnings on gtk 3.10.
> The remaining patches are bug fixes.
>=20
> v2:
>     Add configure patch
>     Fix building against GTK2

I'll go cherry-pick the two warp bugfixes (patches 6+7) for qemu 2.0.

I'll leave the other cleanups for 2.1.  The gtk2/3 compatibility isn't
that easy to get right it seems.  Our current mimimal required gtk
version is 2.18, and on rhel6 (2.20) the build still fails:

  CC    ui/gtk.o
In file included from /usr/include/gtk-2.0/gtk/gtk.h:233,
                 from ui/gtk.c:48:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function
declaration isn=E2=80=99t a prototype
ui/gtk.c: In function =E2=80=98gd_create_menu_machine=E2=80=99:
ui/gtk.c:1308: error: =E2=80=98GDK_KEY_q=E2=80=99 undeclared (first use i=
n this
function)
ui/gtk.c:1308: error: (Each undeclared identifier is reported only once
ui/gtk.c:1308: error: for each function it appears in.)
make: *** [ui/gtk.o] Error 1

cheers,
  Gerd