qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PULL 2/3] gtk: Fix mouse warping with gtk3
Date: Fri, 14 Mar 2014 10:53:27 +0100	[thread overview]
Message-ID: <1394790808-27931-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1394790808-27931-1-git-send-email-kraxel@redhat.com>

From: Cole Robinson <crobinso@redhat.com>

We were using the wrong coordinates, this fixes things to match the
original gtk2 implementation.

You can see this error in action by using -vga qxl, however even after this
patch the mouse warps in small increments up and to the left, -7x and -3y
pixels at a time, until the pointer is warped off the widget. I think it's
a qxl bug, but the next patch covers it up.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 016804d..e2394ac 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -346,7 +346,7 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
                                x, y, &x_root, &y_root);
     gdk_device_warp(gdk_device_manager_get_client_pointer(mgr),
                     gtk_widget_get_screen(s->drawing_area),
-                    x, y);
+                    x_root, y_root);
 }
 #else
 static void gd_mouse_set(DisplayChangeListener *dcl,
-- 
1.8.3.1

  parent reply	other threads:[~2014-03-14  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  9:53 [Qemu-devel] [PULL 0/3] gtk fixes Gerd Hoffmann
2014-03-14  9:53 ` [Qemu-devel] [PULL 1/3] gtk: Allow to activate grab-on-hover from the command line Gerd Hoffmann
2014-03-14  9:53 ` Gerd Hoffmann [this message]
2014-03-14  9:53 ` [Qemu-devel] [PULL 3/3] gtk: Don't warp absolute pointer Gerd Hoffmann
2014-03-14 18:19 ` [Qemu-devel] [PULL 0/3] gtk fixes Peter Maydell
2014-03-17 13:39   ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2014-03-17 13:39 Gerd Hoffmann
2014-03-17 13:39 ` [Qemu-devel] [PULL 2/3] gtk: Fix mouse warping with gtk3 Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394790808-27931-3-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).