From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOp5-0004ra-2K for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOOoz-00008R-2y for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:54:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOoy-000083-Rz for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:54:33 -0400 From: Gerd Hoffmann Date: Fri, 14 Mar 2014 10:53:27 +0100 Message-Id: <1394790808-27931-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1394790808-27931-1-git-send-email-kraxel@redhat.com> References: <1394790808-27931-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 2/3] gtk: Fix mouse warping with gtk3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Anthony Liguori , Cole Robinson From: Cole Robinson We were using the wrong coordinates, this fixes things to match the original gtk2 implementation. You can see this error in action by using -vga qxl, however even after this patch the mouse warps in small increments up and to the left, -7x and -3y pixels at a time, until the pointer is warped off the widget. I think it's a qxl bug, but the next patch covers it up. Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 016804d..e2394ac 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -346,7 +346,7 @@ static void gd_mouse_set(DisplayChangeListener *dcl, x, y, &x_root, &y_root); gdk_device_warp(gdk_device_manager_get_client_pointer(mgr), gtk_widget_get_screen(s->drawing_area), - x, y); + x_root, y_root); } #else static void gd_mouse_set(DisplayChangeListener *dcl, -- 1.8.3.1