From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOQ9W-0008Uw-CW for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:19:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOQ9Q-0001nH-Dh for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:19:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOQ9Q-0001n3-5l for qemu-devel@nongnu.org; Fri, 14 Mar 2014 07:19:44 -0400 Message-ID: <1394795918.5732.12.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 14 Mar 2014 12:18:38 +0100 In-Reply-To: <53218B0D.8000405@redhat.com> References: <1394628914-10758-1-git-send-email-kraxel@redhat.com> <1394628914-10758-4-git-send-email-kraxel@redhat.com> <20140312202611.GB3004@redhat.com> <53218B0D.8000405@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: airlied@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" Hi, > Perhaps a configuration field is better, like this: > > u32 events_read; > u32 events_clear; > > A new event sets a bit in events_read and generates a configuration > change interrupt. The guest should never write to events_read. Makes sense to me. I think I'll go write up things as diff against virtio-wip, then post it for review. cheers, Gerd