From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOTpM-0005ae-PR for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:15:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOTpG-0004P1-R6 for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:15:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOTpG-0004O6-GR for qemu-devel@nongnu.org; Fri, 14 Mar 2014 11:15:10 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2EFF9ri011733 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Mar 2014 11:15:09 -0400 From: Stefan Hajnoczi Date: Fri, 14 Mar 2014 16:14:59 +0100 Message-Id: <1394810099-21028-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1394810099-21028-1-git-send-email-stefanha@redhat.com> References: <1394810099-21028-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] rfifolock: fix bogus coverity warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , "Dr. David Alan Gilbert" Coverity warns about initializing variables that will later be accessed under a mutex. There is no problem with the code itself but let's avoid accumulating Coverity warnings. Signed-off-by: Stefan Hajnoczi --- util/rfifolock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf748..f42214d 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -17,12 +17,14 @@ void rfifolock_init(RFifoLock *r, void (*cb)(void *), void *opaque) { qemu_mutex_init(&r->lock); + qemu_cond_init(&r->cond); + qemu_mutex_lock(&r->lock); r->head = 0; r->tail = 0; - qemu_cond_init(&r->cond); r->nesting = 0; r->cb = cb; r->cb_opaque = opaque; + qemu_mutex_unlock(&r->lock); } void rfifolock_destroy(RFifoLock *r) -- 1.8.5.3