* [Qemu-devel] [PATCH] FSL eTSEC: Fix typo in rx ring
@ 2014-03-14 16:51 Fabien Chouteau
2014-03-14 17:35 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Fabien Chouteau @ 2014-03-14 16:51 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: peter.maydell, agraf, pbonzini
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
hw/net/fsl_etsec/rings.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
index 7760272..31e6f58 100644
--- a/hw/net/fsl_etsec/rings.c
+++ b/hw/net/fsl_etsec/rings.c
@@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
/* TODO: Broadcast and Multicast */
- if (bd.flags | BD_INTERRUPT) {
+ if (bd.flags & BD_INTERRUPT) {
/* Set RXFx */
etsec->regs[RSTAT].value |= 1 << (7 - ring_nbr);
@@ -601,7 +601,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
}
} else {
- if (bd.flags | BD_INTERRUPT) {
+ if (bd.flags & BD_INTERRUPT) {
/* Set IEVENT */
ievent_set(etsec, IEVENT_RXB);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring
2014-03-14 16:51 [Qemu-devel] [PATCH] FSL eTSEC: Fix typo in rx ring Fabien Chouteau
@ 2014-03-14 17:35 ` Michael Tokarev
2014-03-17 17:08 ` Fabien Chouteau
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2014-03-14 17:35 UTC (permalink / raw)
To: Fabien Chouteau; +Cc: qemu-trivial, peter.maydell, pbonzini, qemu-devel, agraf
14.03.2014 20:51, Fabien Chouteau wrote:
> hw/net/fsl_etsec/rings.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index 7760272..31e6f58 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
>
> /* TODO: Broadcast and Multicast */
>
> - if (bd.flags | BD_INTERRUPT) {
> + if (bd.flags & BD_INTERRUPT) {
> /* Set RXFx */
[..etc..]
Hm. Has this code _ever_ worked?? :(
Thanks, applied to -trivial.
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring
2014-03-14 17:35 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-03-17 17:08 ` Fabien Chouteau
0 siblings, 0 replies; 3+ messages in thread
From: Fabien Chouteau @ 2014-03-17 17:08 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, peter.maydell, pbonzini, qemu-devel, agraf
On 03/14/2014 06:35 PM, Michael Tokarev wrote:
> 14.03.2014 20:51, Fabien Chouteau wrote:
>
>> hw/net/fsl_etsec/rings.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
>> index 7760272..31e6f58 100644
>> --- a/hw/net/fsl_etsec/rings.c
>> +++ b/hw/net/fsl_etsec/rings.c
>> @@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
>>
>> /* TODO: Broadcast and Multicast */
>>
>> - if (bd.flags | BD_INTERRUPT) {
>> + if (bd.flags & BD_INTERRUPT) {
>> /* Set RXFx */
> [..etc..]
>
> Hm. Has this code _ever_ worked?? :(
>
Yes because the kernel I'm using always set the BD_INTERRUPT flag.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-17 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-14 16:51 [Qemu-devel] [PATCH] FSL eTSEC: Fix typo in rx ring Fabien Chouteau
2014-03-14 17:35 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-17 17:08 ` Fabien Chouteau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).