qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>
Subject: [Qemu-devel] [PATCH v2 0/4] ARM pl011 fixes
Date: Fri, 14 Mar 2014 13:22:27 -0500	[thread overview]
Message-ID: <1394821351-21477-1-git-send-email-robherring2@gmail.com> (raw)

From: Rob Herring <rob.herring@linaro.org>

Intermittent issues have been seen where no serial input occurs. It
appears the pl011 gets in a state where the rx interrupt never fires
because the rx interrupt only asserts when crossing the fifo trigger
level. The fifo state appears to get out of sync when the pl011 is
re-configured. This combined with the rx timeout interrupt not being
modeled results in no more rx interrupts.

This problem is fixed by the 1st patch. The 3 other patches are problems
I noticed while debugging this issue. They are more for correctness of
the model than fixing any observed issues.

Rob

Rob Herring (4):
  pl011: reset the fifo when enabled or disabled
  pl011: fix UARTRSR accesses corrupting the UARTCR value
  pl011: fix incorrect logic to set the RXFF flag
  pl011: re-evaluate rx interrupt when fifo trigger changes

 hw/char/pl011.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

-- 
1.8.3.2

             reply	other threads:[~2014-03-14 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 18:22 Rob Herring [this message]
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 1/4] pl011: reset the fifo when enabled or disabled Rob Herring
2014-03-16 16:16   ` Peter Maydell
2014-03-16 16:57     ` Peter Maydell
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 2/4] pl011: fix UARTRSR accesses corrupting the UARTCR value Rob Herring
2014-03-16 15:53   ` Peter Maydell
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 3/4] pl011: fix incorrect logic to set the RXFF flag Rob Herring
2014-03-16 15:54   ` Peter Maydell
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 4/4] pl011: re-evaluate rx interrupt when fifo trigger changes Rob Herring
2014-03-16 15:57   ` Peter Maydell
2014-03-16 16:44     ` Peter Maydell
2014-03-17 22:30       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394821351-21477-1-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.herring@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).