From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOWkq-0003HM-EH for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOWkl-0004ju-3Q for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:48 -0400 Received: from mail-oa0-x22d.google.com ([2607:f8b0:4003:c02::22d]:42049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOWkk-0004ji-Tl for qemu-devel@nongnu.org; Fri, 14 Mar 2014 14:22:43 -0400 Received: by mail-oa0-f45.google.com with SMTP id o6so3016629oag.18 for ; Fri, 14 Mar 2014 11:22:41 -0700 (PDT) From: Rob Herring Date: Fri, 14 Mar 2014 13:22:27 -0500 Message-Id: <1394821351-21477-1-git-send-email-robherring2@gmail.com> Subject: [Qemu-devel] [PATCH v2 0/4] ARM pl011 fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Peter Maydell Cc: Rob Herring From: Rob Herring Intermittent issues have been seen where no serial input occurs. It appears the pl011 gets in a state where the rx interrupt never fires because the rx interrupt only asserts when crossing the fifo trigger level. The fifo state appears to get out of sync when the pl011 is re-configured. This combined with the rx timeout interrupt not being modeled results in no more rx interrupts. This problem is fixed by the 1st patch. The 3 other patches are problems I noticed while debugging this issue. They are more for correctness of the model than fixing any observed issues. Rob Rob Herring (4): pl011: reset the fifo when enabled or disabled pl011: fix UARTRSR accesses corrupting the UARTCR value pl011: fix incorrect logic to set the RXFF flag pl011: re-evaluate rx interrupt when fifo trigger changes hw/char/pl011.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) -- 1.8.3.2