qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>
Subject: [Qemu-devel] [PATCH v2 4/4] pl011: re-evaluate rx interrupt when fifo trigger changes
Date: Fri, 14 Mar 2014 13:22:31 -0500	[thread overview]
Message-ID: <1394821351-21477-5-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1394821351-21477-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@linaro.org>

When setting the fifo trigger level, the rx interrupt needs to be asserted
if the current fifo level matches. This is more for correctness as the
level is currently never changed.

Signed-off-by: Rob Herring <rob.herring@linaro.org>
---
 hw/char/pl011.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/char/pl011.c b/hw/char/pl011.c
index 5e664f4..3903933 100644
--- a/hw/char/pl011.c
+++ b/hw/char/pl011.c
@@ -131,6 +131,10 @@ static void pl011_set_read_trigger(PL011State *s)
     else
 #endif
         s->read_trigger = 1;
+
+    if (s->read_count == s->read_trigger) {
+        s->int_level |= PL011_INT_RX;
+    }
 }
 
 static void pl011_write(void *opaque, hwaddr offset,
-- 
1.8.3.2

  parent reply	other threads:[~2014-03-14 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 18:22 [Qemu-devel] [PATCH v2 0/4] ARM pl011 fixes Rob Herring
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 1/4] pl011: reset the fifo when enabled or disabled Rob Herring
2014-03-16 16:16   ` Peter Maydell
2014-03-16 16:57     ` Peter Maydell
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 2/4] pl011: fix UARTRSR accesses corrupting the UARTCR value Rob Herring
2014-03-16 15:53   ` Peter Maydell
2014-03-14 18:22 ` [Qemu-devel] [PATCH v2 3/4] pl011: fix incorrect logic to set the RXFF flag Rob Herring
2014-03-16 15:54   ` Peter Maydell
2014-03-14 18:22 ` Rob Herring [this message]
2014-03-16 15:57   ` [Qemu-devel] [PATCH v2 4/4] pl011: re-evaluate rx interrupt when fifo trigger changes Peter Maydell
2014-03-16 16:44     ` Peter Maydell
2014-03-17 22:30       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394821351-21477-5-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.herring@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).