From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOl0c-0004pZ-EP for qemu-devel@nongnu.org; Sat, 15 Mar 2014 05:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOl0T-0006d7-WA for qemu-devel@nongnu.org; Sat, 15 Mar 2014 05:36:02 -0400 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:53454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOl0T-0006d1-Nd for qemu-devel@nongnu.org; Sat, 15 Mar 2014 05:35:53 -0400 Received: by mail-pd0-f173.google.com with SMTP id z10so3561953pdj.4 for ; Sat, 15 Mar 2014 02:35:52 -0700 (PDT) From: Aakriti Gupta Date: Sat, 15 Mar 2014 15:05:23 +0530 Message-Id: <1394876123-8902-1-git-send-email-aakritty@gmail.com> Subject: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Aakriti Gupta , stefanha@redhat.com This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() (error_setg() is part of error reporting API in include/qapi/error.h) Signed-off-by: Aakriti Gupta --- block/qed.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qed.c b/block/qed.c index 837accd..01fa91b 100644 --- a/block/qed.c +++ b/block/qed.c @@ -650,18 +650,18 @@ static int bdrv_qed_create(const char *filename, QEMUOptionParameter *options, } if (!qed_is_cluster_size_valid(cluster_size)) { - fprintf(stderr, "QED cluster size must be within range [%u, %u] and power of 2\n", + error_setg(errp, "QED cluster size must be within range [%u, %u] and power of 2", QED_MIN_CLUSTER_SIZE, QED_MAX_CLUSTER_SIZE); return -EINVAL; } if (!qed_is_table_size_valid(table_size)) { - fprintf(stderr, "QED table size must be within range [%u, %u] and power of 2\n", + error_setg(errp, "QED table size must be within range [%u, %u] and power of 2", QED_MIN_TABLE_SIZE, QED_MAX_TABLE_SIZE); return -EINVAL; } if (!qed_is_image_size_valid(image_size, cluster_size, table_size)) { - fprintf(stderr, "QED image size must be a non-zero multiple of " - "cluster size and less than %" PRIu64 " bytes\n", + error_setg(errp, "QED image size must be a non-zero multiple of " + "cluster size and less than %" PRIu64 " bytes", qed_max_image_size(cluster_size, table_size)); return -EINVAL; } -- 1.7.9.5