From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPBfK-0007v3-Jh for qemu-devel@nongnu.org; Sun, 16 Mar 2014 10:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPBfF-00023K-II for qemu-devel@nongnu.org; Sun, 16 Mar 2014 10:03:50 -0400 From: Stefan Weil Date: Sun, 16 Mar 2014 15:03:41 +0100 Message-Id: <1394978621-19738-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] target-i386: Add missing 'static' and 'const' attributes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: kvm@vger.kernel.org, Stefan Weil , Marcelo Tosatti , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil --- Why is array para_features in kvm.c terminated by a dummy entry? It is only used in a for loop with upper limit ARRAY_SIZE(para_features) - 1. Regards Stefan target-i386/cpu.c | 2 +- target-i386/kvm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e7e62c5..8fd1497 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -316,7 +316,7 @@ typedef struct X86RegisterInfo32 { #define REGISTER(reg) \ [R_##reg] = { .name = #reg, .qapi_enum = X86_CPU_REGISTER32_##reg } -X86RegisterInfo32 x86_reg_info_32[CPU_NB_REGS32] = { +static const X86RegisterInfo32 x86_reg_info_32[CPU_NB_REGS32] = { REGISTER(EAX), REGISTER(ECX), REGISTER(EDX), diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7a295f6..4389959 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -122,7 +122,7 @@ static struct kvm_cpuid2 *get_supported_cpuid(KVMState *s) return cpuid; } -struct kvm_para_features { +static const struct kvm_para_features { int cap; int feature; } para_features[] = { -- 1.7.10.4