From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPSGA-0007wm-9r for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPSG4-0001dQ-KJ for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:46:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPSG4-0001cz-D9 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 03:46:52 -0400 From: Fam Zheng Date: Mon, 17 Mar 2014 15:46:35 +0800 Message-Id: <1395042401-19291-4-git-send-email-famz@redhat.com> In-Reply-To: <1395042401-19291-1-git-send-email-famz@redhat.com> References: <1395042401-19291-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v3 3/9] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Benoit Canet , Stefan Hajnoczi bdrv_getlength could fail, check the return value before using it. Signed-off-by: Fam Zheng Reviewed-by: Benoit Canet --- block.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d240f1e..e32da75 100644 --- a/block.c +++ b/block.c @@ -5097,7 +5097,12 @@ BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs, } granularity >>= BDRV_SECTOR_BITS; assert(granularity); - bitmap_size = (bdrv_getlength(bs) >> BDRV_SECTOR_BITS); + bitmap_size = bdrv_getlength(bs); + if (bitmap_size < 0) { + error_setg(errp, "could not get length of device"); + return NULL; + } + bitmap_size >>= BDRV_SECTOR_BITS; bitmap = g_malloc0(sizeof(BdrvDirtyBitmap)); bitmap->bitmap = hbitmap_alloc(bitmap_size, ffs(granularity) - 1); if (name) { -- 1.9.0