From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>
Subject: [Qemu-devel] [PULL 1/4] rules.mak: Fix per object libs extraction
Date: Mon, 17 Mar 2014 13:23:14 +0100 [thread overview]
Message-ID: <1395058997-19660-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1395058997-19660-1-git-send-email-pbonzini@redhat.com>
From: Fam Zheng <famz@redhat.com>
Don't sort the extracted options, sort the objects.
Reported-by: Christian Mahnke <cmahnke@googlemail.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
rules.mak | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rules.mak b/rules.mak
index 9dda9f7..5c454d8 100644
--- a/rules.mak
+++ b/rules.mak
@@ -23,8 +23,8 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
QEMU_INCLUDES += -I$(<D) -I$(@D)
maybe-add = $(filter-out $1, $2) $1
-extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs)) \
- $(foreach o,$(call expand-objs,$1),$($o-libs))))
+extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs))) \
+ $(foreach o,$(call expand-objs,$1),$($o-libs)))
expand-objs = $(strip $(sort $(filter %.o,$1)) \
$(foreach o,$(filter %.mo,$1),$($o-objs)) \
$(filter-out %.o %.mo,$1))
--
1.8.5.3
next prev parent reply other threads:[~2014-03-17 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 12:23 [Qemu-devel] [PULL 0/4] Misc fixes for 2.0-rc1 Paolo Bonzini
2014-03-17 12:23 ` Paolo Bonzini [this message]
2014-03-17 12:23 ` [Qemu-devel] [PULL 2/4] qemu-nbd: Fix coverity issues Paolo Bonzini
2014-03-17 12:23 ` [Qemu-devel] [PULL 3/4] target-alpha: fix subl and s8subl indentation Paolo Bonzini
2014-03-17 12:23 ` [Qemu-devel] [PULL 4/4] vl.c: Output error on invalid machine type Paolo Bonzini
2014-03-17 14:06 ` [Qemu-devel] [PULL 0/4] Misc fixes for 2.0-rc1 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395058997-19660-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).