qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
Date: Mon, 17 Mar 2014 13:32:04 +0100	[thread overview]
Message-ID: <1395059524.5663.5.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <alpine.LMD.2.02.1403141856050.15847@jedlik.phy.bme.hu>



> >> C 07  Communication controller
> >>        00  Serial controller
> >>                00  8250
> >>                01  16450
> >>                02  16550

> >> What about multi_serial_pci_init() -- should it too set prog-if
> >> like this?
> >
> > I'm not completely sure what the correct value should be for 
> > multi_serial_pci_init so I've left that alone. There's also 07 02 00 that 
> > means multiport serial controller that might apply for that case. For the 
> > simple case I've sent the patch for I had a client expecting this value so I 
> > think it is correct for that at least but I don't know about the multiport 
> > case.
> 
> Also Gerd Hoffmann said he has picked this patch up so I'm adding him to 
> cc too.

The multiport variants are simply multiple 16550 chips mapped one after
the other.  So "02" is better than "00".

I don't know what exactly the multiport serial controller is supposed to
be.

cheers,
  Gerd

  reply	other threads:[~2014-03-17 12:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  1:05 [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible BALATON Zoltan
2014-03-10 18:40 ` BALATON Zoltan
2014-03-14 16:21   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-14 17:44     ` BALATON Zoltan
2014-03-14 17:57       ` BALATON Zoltan
2014-03-17 12:32         ` Gerd Hoffmann [this message]
2014-03-20  9:58           ` BALATON Zoltan
2014-03-21  8:43             ` Gerd Hoffmann
2014-03-21  9:10               ` BALATON Zoltan
2014-03-20 15:42   ` Michael Tokarev
2014-03-20 15:51     ` Paolo Bonzini
2014-03-20 16:01       ` BALATON Zoltan
2014-03-20 16:32         ` Paolo Bonzini
2014-03-20 16:58           ` BALATON Zoltan
2014-03-20 17:35             ` Paolo Bonzini
2014-03-21  8:19       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395059524.5663.5.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).