From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPWie-0006LY-US for qemu-devel@nongnu.org; Mon, 17 Mar 2014 08:32:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPWiZ-0006RN-0H for qemu-devel@nongnu.org; Mon, 17 Mar 2014 08:32:40 -0400 Message-ID: <1395059524.5663.5.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 17 Mar 2014 13:32:04 +0100 In-Reply-To: References: <20140227011300.8CD451983B@mono.eik.bme.hu> <53232C8C.3070403@msgid.tls.msk.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org > >> C 07 Communication controller > >> 00 Serial controller > >> 00 8250 > >> 01 16450 > >> 02 16550 > >> What about multi_serial_pci_init() -- should it too set prog-if > >> like this? > > > > I'm not completely sure what the correct value should be for > > multi_serial_pci_init so I've left that alone. There's also 07 02 00 that > > means multiport serial controller that might apply for that case. For the > > simple case I've sent the patch for I had a client expecting this value so I > > think it is correct for that at least but I don't know about the multiport > > case. > > Also Gerd Hoffmann said he has picked this patch up so I'm adding him to > cc too. The multiport variants are simply multiple 16550 chips mapped one after the other. So "02" is better than "00". I don't know what exactly the multiport serial controller is supposed to be. cheers, Gerd