From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, patches@linaro.org
Subject: [Qemu-devel] [PATCH v2 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit
Date: Mon, 17 Mar 2014 16:00:40 +0000 [thread overview]
Message-ID: <1395072041-18911-12-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1395072041-18911-1-git-send-email-peter.maydell@linaro.org>
Avoid undefined behaviour shifting left into the sign bit.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/intc/xilinx_intc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
index 4a10398..1b228ff 100644
--- a/hw/intc/xilinx_intc.c
+++ b/hw/intc/xilinx_intc.c
@@ -71,8 +71,9 @@ static void update_irq(struct xlx_pic *p)
/* Update the vector register. */
for (i = 0; i < 32; i++) {
- if (p->regs[R_IPR] & (1 << i))
+ if (p->regs[R_IPR] & (1U << i)) {
break;
+ }
}
if (i == 32)
i = ~0;
--
1.9.0
next prev parent reply other threads:[~2014-03-17 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 16:00 [Qemu-devel] [PATCH v2 00/12] Avoid shifting left into sign bit Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 01/12] target-i386: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 04/12] hw/i386/acpi_build.c: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 05/12] target-mips: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 06/12] hw/usb/hcd-ohci.c: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 07/12] hw/intc/openpic: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 08/12] hw/ppc: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 09/12] tests/libqos/pci-pc: " Peter Maydell
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 10/12] hw/intc/slavio_intctl: " Peter Maydell
2014-03-17 16:00 ` Peter Maydell [this message]
2014-03-17 16:00 ` [Qemu-devel] [PATCH v2 12/12] hw/pci-host/apb.c: " Peter Maydell
2014-03-20 16:04 ` [Qemu-devel] [Qemu-trivial] [PATCH v2 00/12] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395072041-18911-12-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).