From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPcFe-000891-ML for qemu-devel@nongnu.org; Mon, 17 Mar 2014 14:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPcFZ-0006Dk-R3 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 14:27:06 -0400 From: Eduardo Habkost Date: Mon, 17 Mar 2014 15:26:31 -0300 Message-Id: <1395080791-18640-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: Peter Maydell , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Stefan Weil We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost Reviewed-by: Stefan Weil Reviewed-by: Markus Armbruster --- Changes v3: * Wrap long lines Changes v2: * s/be at beginning/be at the beginning/ --- CODING_STYLE | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index dcbce28..4280945 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -84,3 +84,10 @@ and clarity it comes on a line by itself: Rationale: a consistent (except for functions...) bracing style reduces ambiguity and avoids needless churn when lines are added or removed. Furthermore, it is the QEMU coding style. + +5. Declarations + +Mixed declarations (interleaving statements and declarations within blocks) +are not allowed; declarations should be at the beginning of blocks. In other +words, the code should not generate warnings if using GCC's +-Wdeclaration-after-statement option. -- 1.8.5.3